Add warning to PriorDict.evaluate_constraints.#1099
Open
AlexandreGoettel wants to merge 1 commit into
Open
Conversation
Collaborator
|
I am in favor of adding this, since I have fallen into this trap before. I am not sure I feel inclined to just checking against the default conversion function though. Perhaps we should also improve documentation of the PriorDict or the conversion function in both bilby and bilby_pipe to note this fact? Any other opinions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1098
Technically, if the conversion function does not affect some of the constrained parameters they will be ignored too, but to check this would (afaik) require quite some refactoring and I'm not sure it is worth implementing.
However, having talked to people that use Bilby, all of them have been surprised and worried by this behaviour, so this warning, which will affect all cases in which a prior is defined without an explicit conversion function, is a good step imo.