Skip to content

Add warning to PriorDict.evaluate_constraints. #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexandreGoettel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add warning to PriorDict.evaluate_constraints. #1099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bilby/core/prior/dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ def __init__(self, dictionary=None, filename=None, conversion_function=None):
self.conversion_function = self.default_conversion_function

def evaluate_constraints(self, sample):
if self.conversion_function == self.default_conversion_function and type(self).default_conversion_function == PriorDict.default_conversion_function and any(isinstance(v, Constraint) for v in self.values()):
logger.warning("Sampling from prior with Constraints, but no conversion function. The Constraints will be ignored.")
out_sample = self.conversion_function(sample)
try:
prob = np.ones_like(next(iter(out_sample.values())))
Expand Down
Loading