[Regression] Update icon paths for Signal systray images.#772
Open
zquestz wants to merge 1 commit intobilelmoussaoui:masterfrom
Open
[Regression] Update icon paths for Signal systray images.#772zquestz wants to merge 1 commit intobilelmoussaoui:masterfrom
zquestz wants to merge 1 commit intobilelmoussaoui:masterfrom
Conversation
Contributor
|
signal-desktop now uses these files: |
zquestz
changed the title
zquestz
force-pushed
the
signal
branch
2 times, most recently
from
e98041c to
80420be
Compare
Author
|
@abouvier thanks for the heads-up. I have updated the PR to work with their new image layout, however it seems something is wrong decompressing their app.asar file with the latest release! I am getting the following errors trying to apply the new icons. That being said, it appears the icon swap still works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
signal.electron.jsonto swap the signal-desktop systray icons.Fixes #771