fix(mosh): restore Windows reconnect startup#2241
Open
binaricat wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5894f4ce74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Windows Mosh reconnect failure reported in #2240, where reconnecting to some hosts could surface
Mosh SSH startup failed: no MOSH CONNECT from mosh-server (UDP client not started)even though the remotemosh-serverhad started.Root cause
There were two Windows-specific failure modes in the same reconnect path:
netcatty:closebefore reconnecting with the samesessionId. If the old close reached the main process after the new Mosh start, it could kill the replacement SSH bootstrap beforeMOSH CONNECTwas parsed.mosh-serverstartup output. On the reproduced host,MOSH CONNECT <port> <key>was immediately followed by a cursor move and themosh-serverbanner without a CRLF, so the visible terminal showed a valid line while the parser saw key + banner text and rejected the handshake.Changes
netcatty:close:awaitIPC path and proxy it in terminal worker mode.closeSessionawaitable through the preload and renderer backend wrapper, while keeping the legacy fire-and-forget fallback.termRef.currentre-check so close/cancel/unmount cannot start a ghost reconnect.MOSH CONNECTfrom raw ConPTY output by skipping ANSI controls inside the key and stopping cleanly at cursor movement before banner text.Validation
node --test electron\bridges\moshHandshake.test.cjs electron\bridges\terminalBridge.moshHandshakeSession.test.cjsnpm run lint -- --quietMOSH CONNECTbefore visible output is emitted.1.1.68Windows package built from this branch was tested and confirmed to reconnect successfully.