fix: resolve AttributeError in BatchDocumentSummarizer.process_files#2271
Open
octo-patch wants to merge 1 commit into
Open
Conversation
…ixes binary-husky#2226) BatchDocumentSummarizer.__init__ never stored plugin_kwargs, so accessing self.plugin_kwargs in process_files raised AttributeError. The advanced_arg value is already extracted from plugin_kwargs before instantiation and stored as self.query, so replace all self.plugin_kwargs references with self.query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2226
Problem
BatchDocumentSummarizer.__init__does not accept or storeplugin_kwargs, butprocess_files()and related methods referenceself.plugin_kwargsat three locations, causing:Solution
The
advanced_argvalue is already extracted fromplugin_kwargsbefore theBatchDocumentSummarizeris instantiated (line 505 of the same file), and stored asself.query. Replace all three occurrences ofself.plugin_kwargs.get("advanced_arg")/self.plugin_kwargs["advanced_arg"]withself.query, which already holds the same value.Testing
process_filesno longer raisesAttributeErrorand correctly falls back to the default summary prompt when noadvanced_argis provided