security: prevent path traversal in file upload endpoint#2278
Open
anxovatomica wants to merge 1 commit into
Open
security: prevent path traversal in file upload endpoint#2278anxovatomica wants to merge 1 commit into
anxovatomica wants to merge 1 commit into
Conversation
The /upload endpoint used file.filename directly in os.path.join() without sanitizing directory traversal sequences. An attacker could upload a file with filename=../../../tmp/pwned.txt to write outside the intended upload directory. Fix: Use os.path.basename() to strip any path components from the uploaded filename before joining with the upload directory. Fixes potential arbitrary file write vulnerability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The /upload endpoint used file.filename directly in os.path.join() without sanitizing directory traversal sequences.
Fix
Use os.path.basename() to strip path components before joining.
Impact
Remote arbitrary file write via path traversal.
PoC
curl -X POST http:\/\/target:5000\/upload -F "file=@\/dev\/null;filename=..\/..\/..\/tmp\/pwned.txt"