Skip to content

fix: support percentage sizes in wiki link images (#111) #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bingryan merged 1 commit into from
Jan 3, 2026
Merged

fix: support percentage sizes in wiki link images (#111) #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export const ATTACHMENT_URL_REGEXP =
/!\[\[((.*?)\.(\w+))(?:\s*\|\s*(?<width>\d+)\s*(?:[*|x]\s*(?<height>\d+))?)?\]\]/g;
/!\[\[((.*?)\.(\w+))(?:\s*\|\s*(?<width>\d+%?)\s*(?:[*|x]\s*(?<height>\d+%?))?)?\]\]/g;

export const MARKDOWN_ATTACHMENT_URL_REGEXP = /!\[(.*?)\]\(((.*?)\.(\w+))\)/g;

Expand Down
11 changes: 8 additions & 3 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,13 +771,18 @@ export async function tryCopyMarkdownByRead(
if (plugin.settings.displayImageAsHtml) {
const { width = null, height = null } =
imageLinks[index]?.groups || {};
// Helper to format size value - append 'px' only if not a percentage
const formatSize = (value: string | null) => {
if (!value) return "";
return value.includes("%") ? value : `${value}px`;
};
const style =
width && height
? ` style='width: {${width}}px; height: ${height}px;'`
? ` style='width: ${formatSize(width)}; height: ${formatSize(height)};'`
: width
? ` style='width: ${width}px;'`
? ` style='width: ${formatSize(width)};'`
: height
? ` style='height: ${height}px;'`
? ` style='height: ${formatSize(height)};'`
: "";

content = content.replace(
Expand Down