Skip to content

Commit 6f750ce

Browse files
committed
vcftools: minor changes after review
1 parent 056869e commit 6f750ce

4 files changed

Lines changed: 4 additions & 3 deletions

File tree

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,4 @@ log = "0.4.27"
1818
serial_test = "3.1"
1919
tempfile = "3.15"
2020
parquet = "56.1"
21+
async-trait = "0.1.88"

datafusion/bio-function-vcftools/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ datafusion = { workspace = true }
1313
tokio = { workspace = true }
1414
futures = { workspace = true }
1515
log = { workspace = true }
16-
async-trait = "0.1.88"
16+
async-trait = { workspace = true }
1717

1818
[dev-dependencies]
1919
tokio = { workspace = true, features = ["rt-multi-thread", "macros"] }

datafusion/bio-function-vcftools/src/physical/fused_array_transform_exec.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ impl FusedArrayTransformStream {
382382
let mut all_values: Vec<ArrayRef> = Vec::with_capacity(ctx.num_rows);
383383
let mut offsets: Vec<i32> = vec![0];
384384
let mut null_bitmap: Vec<bool> = Vec::with_capacity(ctx.num_rows);
385-
let mut current_offset: i32 = 0;
385+
let mut current_offset: i32 = 0; // TODO: consider switching to i64
386386

387387
// Pre-compute the mini-batch schema once - it's the same for all rows.
388388
let mini_batch_schema =

datafusion/bio-function-vcftools/tests/integration_test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,7 @@ async fn test_mismatched_array_lengths() {
971971
let df_optimized2 = ctx_optimized.sql(sql).await.unwrap();
972972
let optimized_results = df_optimized2.collect().await.unwrap();
973973

974-
// Both baseline and optimized should filter out the empty-array row and have identical output
974+
// Both baseline and optimized should handle mismatched lengths gracefully and produce identical output
975975
let baseline_str = pretty_format_batches(&baseline_results)
976976
.unwrap()
977977
.to_string();

0 commit comments

Comments
 (0)