vcftools: reuse DefaultPhysicalPlanner

Author: psuszyns

datafusion/bio-function-vcftools/src/physical/query_planner.rs

@@ -15,13 +15,33 @@ use super::extension_planner::FusedArrayTransformPlanner;
 
 /// A custom QueryPlanner that uses a physical planner configured with
 /// the FusedArrayTransformPlanner extension for handling FusedArrayTransform nodes.
-#[derive(Debug, Default)]
-pub struct VcfQueryPlanner;
+///
+/// The physical planner is initialized once and reused for all queries,
+/// avoiding repeated allocations since both DefaultPhysicalPlanner and
+/// FusedArrayTransformPlanner are stateless.
+pub struct VcfQueryPlanner {
+    physical_planner: DefaultPhysicalPlanner,
+}
+
+impl std::fmt::Debug for VcfQueryPlanner {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct("VcfQueryPlanner").finish()
+    }
+}
+
+impl Default for VcfQueryPlanner {
+    fn default() -> Self {
+        Self::new()
+    }
+}
 
 impl VcfQueryPlanner {
-    /// Create a new VcfQueryPlanner.
+    /// Create a new VcfQueryPlanner with a pre-configured physical planner.
     pub fn new() -> Self {
-        Self
+        let physical_planner = DefaultPhysicalPlanner::with_extension_planners(vec![Arc::new(
+            FusedArrayTransformPlanner::new(),
+        )]);
+        Self { physical_planner }
     }
 }
 
@@ -32,15 +52,10 @@ impl QueryPlanner for VcfQueryPlanner {
         logical_plan: &LogicalPlan,
         session_state: &SessionState,
     ) -> datafusion::common::Result<Arc<dyn ExecutionPlan>> {
-        // Create a physical planner with our extension planner for FusedArrayTransform
-        let physical_planner = DefaultPhysicalPlanner::with_extension_planners(vec![Arc::new(
-            FusedArrayTransformPlanner::new(),
-        )]);
-
         let display_string = logical_plan.display();
         info!("VcfQueryPlanner: Creating physical plan for logical plan: {display_string}");
 
-        physical_planner
+        self.physical_planner
             .create_physical_plan(logical_plan, session_state)
             .await
     }