Skip to content

Commit dbae347

Browse files
committed
refactor: remove dead implicit_solver and broken PlotProps
implicit_solver ended with raise NotImplementedError() and could never produce results. PlotProps imported a nonexistent 'vanGenuchten' module. Unknown solver names now raise ValueError instead of silently falling through to rk4.
1 parent e985577 commit dbae347

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

porousmedialab/lab.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -328,9 +328,6 @@ def reactions_integrate_scipy(self, i):
328328
i {int} -- step in time
329329
"""
330330

331-
# C_new, rates_per_elem, rates_per_rate = desolver.ode_integrate(self.profiles, self.dcdt, self.rates, self.constants, self.dt, solver='rk4')
332-
# C_new, rates_per_elem = desolver.ode_integrate(self.profiles, self.dcdt, self.rates, self.constants, self.dt, solver='rk4')
333-
# for idx_j in range(self.N):
334331
yinit = np.zeros(len(self.species)) # Pre-allocate outside loop
335332
for idx_j in range(self.N):
336333
for idx, s in enumerate(self.species):

0 commit comments

Comments
 (0)