Skip to content

Commit c00cd3f

Browse files
committed
Address follow-up version review
1 parent 94d71a6 commit c00cd3f

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

src/nodenorm/handlers/version.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import asyncio
2-
31
from biothings.web.handlers import BaseHandler
42

53
from nodenorm.version import get_version
@@ -9,6 +7,4 @@ class VersionHandler(BaseHandler):
97
name = "version"
108

119
async def get(self, *args, **kwargs):
12-
loop = asyncio.get_running_loop()
13-
version = await loop.run_in_executor(None, get_version)
14-
self.write({"version": version})
10+
self.write({"version": get_version()})

tests/test_version.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ def clear_version_caches():
88
nodenorm_version.get_github_commit_hash.cache_clear()
99
nodenorm_version.get_version.cache_clear()
1010
yield
11-
nodenorm_version.get_github_commit_hash.cache_clear()
12-
nodenorm_version.get_version.cache_clear()
1311

1412

1513
def test_read_version_file_uses_configured_path(tmp_path, monkeypatch):

0 commit comments

Comments
 (0)