Skip to content

Swap Colors for official GNOME names and move to seperate file#3

Open
Haaruun-I wants to merge 4 commits into
birneee:mainfrom
Haaruun-I:main
Open

Swap Colors for official GNOME names and move to seperate file#3
Haaruun-I wants to merge 4 commits into
birneee:mainfrom
Haaruun-I:main

Conversation

@Haaruun-I

Copy link
Copy Markdown

exactly what the title says, light mode is slightly off but the gradiance integration should fix it

@birneee

birneee commented Jan 8, 2023

Copy link
Copy Markdown
Owner

Thank you for your work.
Looks good but it think it requires some refinement.

  • Dark and Light theme should work even without the Gradience integration
  • to avoid variable naming conflicts we should add some prefix e.g. adw-
  • i think the tilebar-background should be the headerbar-backdrop-color
  • i am not sure why you removed the .is-focused rules

@Haaruun-I

Copy link
Copy Markdown
Author

Hi, sorry for the late reply, i was a bit busy this week
About those isues,

  • The only issue with light theme the highlight color matching the background on the file picker sidebar, which means it only gets bolded and not a background change
    image
  • Good idea, ill do that now
  • same ^
  • I didnt see the focused colors used anywhere and they were the same colors as the non-focused most of the times anyways

@birneee

birneee commented Jan 22, 2023

Copy link
Copy Markdown
Owner

@Haaruun-I The focused colors are used, when the window is in focus.

@birneee

birneee commented Jan 22, 2023

Copy link
Copy Markdown
Owner

@Haaruun-I for me the light theme looks quite unusable. Does it look different for you?

When window in focus:
Screenshot from 2023-01-22 15-59-08

When window not in focus:
Screenshot from 2023-01-22 15-59-27

@birneee

birneee commented Jul 30, 2023

Copy link
Copy Markdown
Owner

d6ceb70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants