Skip to content

Change sim fov#683

Closed
val-ba wants to merge 64 commits intofeature/jazzy-ubuntu2404-devcontainerfrom
fix/change_sim_FOV
Closed

Change sim fov#683
val-ba wants to merge 64 commits intofeature/jazzy-ubuntu2404-devcontainerfrom
fix/change_sim_FOV

Conversation

@val-ba
Copy link
Copy Markdown
Contributor

@val-ba val-ba commented Mar 27, 2025

Summary

Should fix #497
This is based on the jazzy dev branch though.

Proposed changes

Change fov in wolfgang.proto from 1.04 to 1.517

Related issues

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

val-ba and others added 30 commits November 15, 2024 13:04
which was not held consistent with the `robot.urdf` joint limits
Co-authored-by: David Nguyen <nguyendavid2512@gmail.com>
Co-authored-by: Pär <paer-wiegmann@gmx.de>
Co-authored-by: Helena Jäger <helena.jaeger@studium.uni-hamburg.de>
Co-authored-by: Lea <lea.schaper@studium.uni-hamburg.de>
Co-authored-by: Pär Wiegmann <paer-wiegmann@gmx.de>
@github-project-automation github-project-automation Bot moved this to 🆕 New in Software Mar 27, 2025
@val-ba val-ba requested review from Flova, jaagut and texhnolyze March 27, 2025 11:10
@val-ba val-ba moved this from 🆕 New to 👀 In review in Software Mar 27, 2025
@val-ba val-ba self-assigned this Mar 27, 2025
@Flova
Copy link
Copy Markdown
Member

Flova commented Mar 27, 2025

I think you might have used the wrong base branch. There are a lot of changes here

@val-ba val-ba changed the base branch from main to feature/jazzy-ubuntu2404-devcontainer March 27, 2025 11:13
@texhnolyze texhnolyze force-pushed the feature/jazzy-ubuntu2404-devcontainer branch from 2860b1a to d9191c6 Compare March 27, 2025 11:14
@val-ba val-ba closed this Mar 27, 2025
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Software Mar 27, 2025
@val-ba val-ba deleted the fix/change_sim_FOV branch March 27, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Camera FOV in simulation differs from real world.

9 participants