Skip to content

fix: minor translation adjustments#2504

Open
goingforstudying-ctrl wants to merge 1 commit into
bit-team:devfrom
goingforstudying-ctrl:fix/ssh-translation-typo
Open

fix: minor translation adjustments#2504
goingforstudying-ctrl wants to merge 1 commit into
bit-team:devfrom
goingforstudying-ctrl:fix/ssh-translation-typo

Conversation

@goingforstudying-ctrl
Copy link
Copy Markdown

@goingforstudying-ctrl goingforstudying-ctrl commented May 28, 2026

Summary

This PR addresses the minor translation adjustments requested in #2477:

  1. Capitalize SSH in user-facing prompt ():

    • Changed "Copy public ssh-key ..." → "Copy public SSH key ..."
    • Keeps "ssh-agent" lowercase where appropriate (binary name).

  2. Add missing period ():

    • Changed "No config found in this directory" → "No config found in this directory."

Checklist

  • Changes are minimal and focused on the reported issue
  • No functional code changes

Closes #2477

@buhtz
Copy link
Copy Markdown
Member

buhtz commented May 28, 2026

Hello,
thank you for this contribution.

Did you checked if there are any other SSH related sources strings that should be changed?

Regards,
Christian

@buhtz buhtz added Feedback needs user response, may be closed after timeout without a response PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. PR: Modifications requested Maintenance team requested modifications and waiting for their implementation labels May 28, 2026
@buhtz buhtz added this to the Upcoming next (2.0.0) milestone May 28, 2026
@goingforstudying-ctrl
Copy link
Copy Markdown
Author

goingforstudying-ctrl commented May 28, 2026

Hi Christian, thanks for the review. I checked the codebase for other SSH-related user-facing strings and these two were the only ones that needed fixing. The ssh-agent binary name is intentionally left lowercase since that's the actual command name. Let me know if you spot anything else.

buhtz
buhtz approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@buhtz buhtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
On behalf of the team, thank you for your contribution and taking the time to improve Back In Time. We appreciate it.

Your PR looks fine. It will get merged after PR #2449 is merged.

To find out how we usually tread PRs please read
"What happens after you opened a PullRequest (PR)?".

Best,
Christian

@buhtz buhtz added PR: Merge after creative-break Merge after creative-break (~1 week) and removed PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. PR: Modifications requested Maintenance team requested modifications and waiting for their implementation labels May 28, 2026
@buhtz buhtz removed the Feedback needs user response, may be closed after timeout without a response label May 28, 2026
@goingforstudying-ctrl
Copy link
Copy Markdown
Author

goingforstudying-ctrl commented May 30, 2026

Hi @buhtz — thanks again for the approval. I rebased the branch onto the latest main to keep it mergeable. Looking forward to seeing it merged after #2449 lands.

@buhtz
Copy link
Copy Markdown
Member

buhtz commented May 30, 2026

Now you have "349 changed files" in this PR. Looks like something have gone south?

fix: minor translation adjustments
a846d02 
- Capitalize 'SSH' in user-facing prompt in sshtools.py
  ('Copy public ssh-key' → 'Copy public SSH key')
- Add missing period at end of sentence in restoreconfigdialog.py
  ('No config found in this directory' → 'No config found in this directory.')

Closes bit-team#2477
@goingforstudying-ctrl
Copy link
Copy Markdown
Author

goingforstudying-ctrl commented May 30, 2026

Hi @buhtz, thanks for catching that. The rebase went wrong and pulled in the entire dev branch history, which is why there were 394 changed files. I have force-pushed a clean branch with just the two original translation fixes (capitalizing SSH and adding the missing period). The PR should now show only 2 changed files again. Sorry for the noise.

@goingforstudying-ctrl
Copy link
Copy Markdown
Author

goingforstudying-ctrl commented Jun 1, 2026

Hi, just checking in on this PR. It has been 2 days since the last update. Please let me know if there is anything else needed from my side to move this forward. Thanks for your time.

@buhtz
Copy link
Copy Markdown
Member

buhtz commented Jun 2, 2026

Hello,

is anything else needed from my side to move this forward

Just wait until PR #2449 gets merged and I am solving merge conflicts.

To find out how we usually tread PRs please read
"What happens after you opened a PullRequest (PR)?".

Regards,
Christian

@goingforstudying-ctrl
Copy link
Copy Markdown
Author

goingforstudying-ctrl commented Jun 3, 2026

Thanks for the update, buhtz. I will wait for PR #2449 to be merged. Let me know if anything else is needed from my side in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buhtz buhtz buhtz approved these changes

Assignees

@goingforstudying-ctrl goingforstudying-ctrl

Labels

PR: Merge after creative-break Merge after creative-break (~1 week)

Projects

None yet

Milestone

Upcoming next (2.0.0)

Development

Successfully merging this pull request may close these issues.

Minor translation adjustments

2 participants

@goingforstudying-ctrl @buhtz