CODEBASE: Update node-forge & js-yaml packages due to vulnerabilities#2405
Merged
Conversation
of the node-forge and js-yaml packages. node-forge was vulnerable to * https://github.com/digitalbazaar/forge * [CVE-2025-66031](GHSA-554w-wpv2-vw27) - node-forge ASN.1 Unbounded Recursion (High severity) * [ CVE-2025-12816](GHSA-5gfm-wpxj-wjgq) - node-forge has an Interpretation Conflict vulnerability via its ASN.1 Validator Desynchronization (High severity) * [CVE-2025-66030](GHSA-65ch-62r8-g69g) - node-forge is vulnerable to ASN.1 OID Integer Truncation (Moderate severity) node-forge (or Forge) is "A native implementation of TLS in Javascript and tools to write crypto-based and network-heavy webapps" and is a dependency of `webpack-dev-server` in BitBurner. ASN.1 is a horribly complex interface description language, and has been a rich source of cryptography related security bugs for decades. js-yaml was vulnerable to * [CVE-2025-64718](GHSA-mh29-5h37-fv8m) - js-yaml has prototype pollution in merge (<<) (Moderate severity) * https://github.com/nodeca/js-yaml js-yaml is used by Jest, Babel, ESLint, and api-documenter. Ran `npm test`, `npm run build:dev`, `npm run electron`, `npm run format:report` and `npm run lint:report`. My system has been updated to [npm 11.6.4](https://docs.npmjs.com/cli/v11/using-npm/changelog), which seems to have changed it behaviour about `peer` dependencies, so several automatically added peer dependency has been removed from `package-lock.json`. This behaviour may not been seen if you use a different `npm` version.
Collaborator
|
Note to self/future: npm/cli#8671 (the release notes for npm 11.6.3) contains the following:
This tells me that we shouldn't commit any new changes with 11.6.2, but only either earlier or (preferably) later versions. |
Collaborator
|
Also of note: This updates api-documenter. But, if no changes are seen by the doc check, that should be fine. |
antoinedube
pushed a commit
to antoinedube/bitburner-source
that referenced
this pull request
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
of the node-forge and js-yaml packages.
node-forge was vulnerable to
https://github.com/digitalbazaar/forge
CVE-2025-66031 - node-forge ASN.1 Unbounded Recursion (High severity)
CVE-2025-12816 - node-forge has an Interpretation Conflict vulnerability via its ASN.1 Validator Desynchronization (High severity)
CVE-2025-66030 - node-forge is vulnerable to ASN.1 OID Integer Truncation (Moderate severity)
node-forge (or Forge) is "A native implementation of TLS in Javascript and tools to write crypto-based and network-heavy webapps" and is a dependency of
webpack-dev-serverin BitBurner.ASN.1 is a horribly complex interface description language, and has been a rich source of cryptography related security bugs for decades.
js-yaml was vulnerable to
js-yaml is used by Jest, Babel, ESLint, and api-documenter.
Ran
npm test,npm run build:dev,npm run electron,npm run format:reportandnpm run lint:report.My system has been updated to npm 11.6.4, which seems to have changed it behaviour about
peerdependencies, so several automatically added peer dependency has been removed frompackage-lock.json. This behaviour may not been seen if you use a differentnpmversion.