made some new function names a bit shorter.

Author: matas-bitbybit-dev

packages/dev/base/lib/api/services/point.ts

@@ -755,10 +755,10 @@ export class Point {
      * @param inputs Points, checkLastWithFirst flag, and tolerance
      * @returns Array of maximum fillet radii for each corner
      * @group fillet
-     * @shortname max fillet radius half line
+     * @shortname max fillets half line
      * @drawable false
      */
-    pointsMaxFilletsHalfLine(
+    maxFilletsHalfLine(
         inputs: Inputs.Point.PointsMaxFilletsHalfLineDto
     ): number[] {
         const { points, checkLastWithFirst = false, tolerance = 1e-7 } = inputs;
@@ -833,7 +833,7 @@ export class Point {
     safestPointsMaxFilletHalfLine(
         inputs: Inputs.Point.PointsMaxFilletsHalfLineDto
     ): number {
-        const allMaxRadii = this.pointsMaxFilletsHalfLine(inputs);
+        const allMaxRadii = this.maxFilletsHalfLine(inputs);
 
         if (allMaxRadii.length === 0) {
             // No corners, or fewer than 3 points. No fillet possible.

packages/dev/base/lib/api/services/polyline.test.ts

@@ -751,15 +751,15 @@ describe("Polyline unit tests", () => {
         it("should return an empty array for fewer than 3 points", () => {
             const points: Inputs.Base.Point3[] = [[0, 0, 0], [1, 1, 0]];
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points } };
-            expect(polyline.polylineMaxFilletRadii(input)).toEqual([]);
+            expect(polyline.maxFilletsHalfLine(input)).toEqual([]);
         });
 
         it("should calculate fillet for the single corner of a 3-point open polyline", () => {
             const points: Inputs.Base.Point3[] = [[0, 0, 0], [5, 0, 0], [5, 3, 0]]; // 90 deg corner at [5,0,0]
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points, isClosed: false } };
             const expectedRadii = [1.5];
 
-            const result = polyline.polylineMaxFilletRadii(input);
+            const result = polyline.maxFilletsHalfLine(input);
             uh.expectFloatArraysClose(result, expectedRadii, precision);
         });
 
@@ -768,7 +768,7 @@ describe("Polyline unit tests", () => {
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points, isClosed: false } };
             const expectedRadii = [1.5, 1.5];
 
-            const result = polyline.polylineMaxFilletRadii(input);
+            const result = polyline.maxFilletsHalfLine(input);
             uh.expectFloatArraysClose(result, expectedRadii, precision);
         });
 
@@ -777,7 +777,7 @@ describe("Polyline unit tests", () => {
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points, isClosed: true } };
             const expectedRadii = [2/3, 1.5, 0.75];
 
-            const result = polyline.polylineMaxFilletRadii(input);
+            const result = polyline.maxFilletsHalfLine(input);
             uh.expectFloatArraysClose(result, expectedRadii, precision);
         });
 
@@ -786,7 +786,7 @@ describe("Polyline unit tests", () => {
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points, isClosed: true } };
             const expectedRadii = [1.5, 1.5, 1.5, 1.5];
 
-            const result = polyline.polylineMaxFilletRadii(input);
+            const result = polyline.maxFilletsHalfLine(input);
             uh.expectFloatArraysClose(result, expectedRadii, precision);
         });
 
@@ -795,7 +795,7 @@ describe("Polyline unit tests", () => {
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points, isClosed: false } };
             const expectedRadii = [0.0, 1.5];
 
-            const result = polyline.polylineMaxFilletRadii(input);
+            const result = polyline.maxFilletsHalfLine(input);
             uh.expectFloatArraysClose(result, expectedRadii, precision);
         });
 
@@ -805,7 +805,7 @@ describe("Polyline unit tests", () => {
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points, isClosed: false }, tolerance: customTolerance };
             const expectedRadii = [0.0];
 
-            const result = polyline.polylineMaxFilletRadii(input);
+            const result = polyline.maxFilletsHalfLine(input);
             uh.expectFloatArraysClose(result, expectedRadii, precision);
         });
 
@@ -816,26 +816,26 @@ describe("Polyline unit tests", () => {
         it("should return 0 if calculatePolylineMaxFillets returns an empty array", () => {
             const points: Inputs.Base.Point3[] = [[0, 0, 0], [1, 1, 0]];
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points } };
-            expect(polyline.safestPolylineFilletRadius(input)).toBe(0);
+            expect(polyline.safestFilletRadius(input)).toBe(0);
         });
 
         it("should return the minimum of the calculated radii", () => {
             const points: Inputs.Base.Point3[] = [[0,0,0], [4,0,0], [0,3,0]];
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points, isClosed: true } };
             const expectedSafest = 2/3;
-            expect(polyline.safestPolylineFilletRadius(input)).toBeCloseTo(expectedSafest, precision);
+            expect(polyline.safestFilletRadius(input)).toBeCloseTo(expectedSafest, precision);
         });
 
         it("should return 0 if any calculated radius is 0", () => {
             const points: Inputs.Base.Point3[] = [[0, 0, 0], [5, 0, 0], [10, 0, 0], [10, 3, 0]];
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points, isClosed: false } };
-            expect(polyline.safestPolylineFilletRadius(input)).toBeCloseTo(0.0, precision);
+            expect(polyline.safestFilletRadius(input)).toBeCloseTo(0.0, precision);
         });
 
         it("should return the single radius if only one corner exists", () => {
             const points: Inputs.Base.Point3[] = [[0, 0, 0], [5, 0, 0], [5, 3, 0]];
             const input: Inputs.Polyline.PolylineToleranceDto = { polyline: { points, isClosed: false } };
-            expect(polyline.safestPolylineFilletRadius(input)).toBeCloseTo(1.5, precision);
+            expect(polyline.safestFilletRadius(input)).toBeCloseTo(1.5, precision);
         });
     });
 

packages/dev/base/lib/api/services/polyline.ts

@@ -467,10 +467,10 @@ export class Polyline {
      * @shortname polyline max fillet radii
      * @drawable false
      */
-    polylineMaxFilletRadii(
+    maxFilletsHalfLine(
         inputs: Inputs.Polyline.PolylineToleranceDto
     ): number[] {
-        return this.point.pointsMaxFilletsHalfLine({
+        return this.point.maxFilletsHalfLine({
             points: inputs.polyline.points,
             checkLastWithFirst: inputs.polyline.isClosed,
             tolerance: inputs.tolerance,
@@ -491,10 +491,10 @@ export class Polyline {
      * @shortname polyline safest fillet radius
      * @drawable false
      */
-    safestPolylineFilletRadius(
+    safestFilletRadius(
         inputs: Inputs.Polyline.PolylineToleranceDto
     ): number {
-        const allMaxRadii = this.polylineMaxFilletRadii(inputs);
+        const allMaxRadii = this.maxFilletsHalfLine(inputs);
 
         if (allMaxRadii.length === 0) {
             // No corners, or fewer than 3 points. No fillet possible.