fixed bugs that were caused by extended properties on cube and cylinder

Author: matas-bitbybit-dev

packages/dev/occt/lib/services/base/solids.service.ts

@@ -32,6 +32,9 @@ export class SolidsService {
 
     createBox(inputs: Inputs.OCCT.BoxDto): TopoDS_Solid {
         let center = [...inputs.center];
+        if (inputs.originOnCenter === undefined) {
+            inputs.originOnCenter = true;
+        }
         if (!inputs.originOnCenter) {
             center = [center[0], center[1] + inputs.height / 2, center[2]];
         }
@@ -40,6 +43,9 @@ export class SolidsService {
 
     createCube(inputs: Inputs.OCCT.CubeDto): TopoDS_Solid {
         let center = [...inputs.center];
+        if (inputs.originOnCenter === undefined) {
+            inputs.originOnCenter = true;
+        }
         if (!inputs.originOnCenter) {
             center = [center[0], center[1] + inputs.size / 2, center[2]];
         }
@@ -56,7 +62,12 @@ export class SolidsService {
     createCylinder(inputs: Inputs.OCCT.CylinderDto): TopoDS_Solid {
         const dir = inputs.direction ? inputs.direction : [0., 1., 0.];
         let result;
-        const angle = this.vectorHelperService.degToRad(inputs.angle);
+        let angle;
+        if (inputs.angle === undefined) {
+            angle = Math.PI * 2;
+        } else {
+            angle = this.vectorHelperService.degToRad(inputs.angle);
+        }
         const cyl = this.entitiesService.bRepPrimAPIMakeCylinder(
             inputs.center,
             dir as Base.Vector3,

packages/dev/occt/lib/services/shapes/edge.test.ts

@@ -371,7 +371,7 @@ describe("OCCT edge unit tests", () => {
     });
 
     it("should get edge lengths", async () => {
-        const cylinder = occHelper.entitiesService.bRepPrimAPIMakeCylinder([0, 0, 0], [0, 1, 0], 1, 2, 360);
+        const cylinder = occHelper.entitiesService.bRepPrimAPIMakeCylinder([0, 0, 0], [0, 1, 0], 1, 2, Math.PI * 2);
         const edges = edge.getEdges({ shape: cylinder });
         const lengths = edge.getEdgesLengths({ shapes: edges });
         expect(lengths.length).toBe(3);

packages/dev/occt/lib/services/shapes/solid.test.ts

@@ -64,7 +64,7 @@ describe("OCCT solid unit tests", () => {
     });
 
     it("should create a cylinder solid", async () => {
-        const cylinder = solid.createCylinder({ radius: 2, height: 2, center: [0, 0, 0], direction: [0, 0, 1] });
+        const cylinder = solid.createCylinder({ radius: 2, height: 2, center: [0, 0, 0], direction: [0, 0, 1], angle: 360 });
         expect(solid.getSolidVolume({ shape: cylinder })).toBeCloseTo(25.13274122871834);
         cylinder.delete();
     });