ci: avoid bugprone-unused-return-value lint in test

Sjors · ryanofsky · Sjors · commit 16dfc3686401 · 2026-02-25T12:12:48.000-03:00
Needed for clang-22 tidy job, see: bitcoin/bitcoin#34662 Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
diff --git a/test/mp/test/test.cpp b/test/mp/test/test.cpp
@@ -97,7 +97,7 @@ class TestSetup
                   client_connection->m_rpc_system->bootstrap(ServerVatId().vat_id).castAs<messages::FooInterface>(),
                   client_connection.get(), /* destroy_connection= */ client_owns_connection);
               if (client_owns_connection) {
-                  client_connection.release();
+                  (void)client_connection.release();
               } else {
                   client_disconnect = [&] { loop.sync([&] { client_connection.reset(); }); };
               }

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ class TestSetup`
`97`	`97`	`client_connection->m_rpc_system->bootstrap(ServerVatId().vat_id).castAs<messages::FooInterface>(),`
`98`	`98`	`client_connection.get(), /* destroy_connection= */ client_owns_connection);`
`99`	`99`	`if (client_owns_connection) {`
`100`		`- client_connection.release();`
	`100`	`+ (void)client_connection.release();`
`101`	`101`	`} else {`
`102`	`102`	`client_disconnect = [&] { loop.sync([&] { client_connection.reset(); }); };`
`103`	`103`	`}`