Commit 9cc3479
committed
Merge #291: cmake: Add
16362f4 cmake: Add `mp_headers` custom target (Hennadii Stepanov)
Pull request description:
The new `mp_headers` target acts as a build-graph node for generated Cap'n Proto C++ headers. By providing this custom target, other targets that include the headers can properly order themselves after the generation step without needing to depend on the library target that also uses them.
This convenience target is necessary for proper build dependency management, as the underlying `capnp_generate_cpp` function is not [`CODEGEN`](https://cmake.org/cmake/help/latest/policy/CMP0171.html)-aware.
Required for bitcoin/bitcoin#35468.
ACKs for top commit:
ryanofsky:
Code review ACK 16362f4. Thanks for implementing this. It should make it easier to have control over generated code.
Tree-SHA512: c3551b14fce54a65ac0577c8e39e25a3b0c6cff7a58a9383c73bc8f21078c1a944be57c0ccab2080d67b836a0b6cc4e33a60255fc9ca7dc1a8aa2a222c9152dfmp_headers custom target1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
142 | 146 | | |
143 | 147 | | |
144 | 148 | | |
| |||
0 commit comments