Open
Conversation
Collaborator
|
Looks good! I also had a look at https://mempool.space/mining/pool/gdpool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This adds
GDPoolto the mining pool dataset with tagsGDPoolandLucky pool, paying to1DnPPFQPrfyNTiHPXhDFyqNnW9T62GEhB1. Both tags are required: the operator rebranded fromLucky pooltoGDPoolon the same payout address, and keeping both ensures historical blocks stay attributed.Closes #101.
Context
GDPoolandLucky poolare the same pool, not two distinct operators. The parallelmempool/mining-poolsdataset carried this pool asluckyPooluntil PR #90 (merged 2025-11-26) renamed the entry toGDPool, keeping the same pool id, the same single payout address, and theLucky poolregex alongside the newGDPoolregex. Block903840carries theLucky poolcoinbase text while later blocks carryGDPool, all paying the same address.Issue #101 also mentions
Miningcoreas a candidate name. The earliest three blocks from this operator (heights808964,810717,812535, Sept–Oct 2023) do carry aMiningcorecoinbase tag, butMiningcoreis the default string emitted by the open-source Miningcore pool software rather than a pool name/branc. Adding it as a tag here would mis-attribute any other self-hosted Miningcore BTC pool to GDPool (if there are any, haven't checked); the three blocks in question already pay1DnPPFQPrfyNTiHPXhDFyqNnW9T62GEhB1and are therefore attributed via the address match regardless.Evidence
Coinbase tag evidence for
GDPool:906701: scriptSig ends with064744506f6f6c(GDPool), pays to1DnPPFQPrfyNTiHPXhDFyqNnW9T62GEhB1908662: scriptSig ends with064744506f6f6c(GDPool), pays to1DnPPFQPrfyNTiHPXhDFyqNnW9T62GEhB1Coinbase tag evidence for
Lucky pool:903840: scriptSig ends with0a4c75636b7920706f6f6c(Lucky pool), pays to1DnPPFQPrfyNTiHPXhDFyqNnW9T62GEhB1Testing
python3 qa/check-data.pypython3 contrib/generate-old-pools-json.py