fix: added code review suggestions

Author: r1b2ns

BDKSwiftExampleWallet/View/Home/ActivityHomeHeaderView.swift

@@ -23,7 +23,7 @@ struct ActivityHomeHeaderView: View {
             Spacer()
 
             HStack {
-                if case let .fullSyncing(inspectedScripts) = state {
+                if needsFullScan {
                     Text("\(inspectedScripts)")
                         .padding(.trailing, -5.0)
                         .fontWeight(.semibold)
@@ -34,8 +34,7 @@ struct ActivityHomeHeaderView: View {
                         .font(.caption2)
                         .fontWeight(.thin)
                         .animation(.easeInOut, value: inspectedScripts)
-                }
-                if case let .syncing(progress, inspectedScripts, totalScripts) = state {
+                } else if walletSyncState == .syncing {
                     HStack {
                         if progress < 1.0 {
                             Text("\(inspectedScripts)")
@@ -72,15 +71,15 @@ struct ActivityHomeHeaderView: View {
             }
             HStack {
                 HStack(spacing: 5) {
-                    state.syncImageIndicator
+                    self.syncImageIndicator()
                 }
                 .contentTransition(.symbolEffect(.replace.offUp))
 
             }
             .foregroundStyle(.secondary)
             .font(.caption)
 
-            if case .synced = state {
+            if walletSyncState == .synced {
                 Button {
                     self.showAllTransactions()
                 } label: {
@@ -96,33 +95,30 @@ struct ActivityHomeHeaderView: View {
         }
         .fontWeight(.bold)
     }
-}
-
-
-fileprivate extension ActivityHomeHeaderView.State {
 
-    var syncImageIndicator: some View {
-        switch self {
+    @ViewBuilder
+    private func syncImageIndicator() -> some View {
+        switch walletSyncState {
         case .synced:
-            return AnyView(
+            AnyView(
                 Image(systemName: "checkmark.circle.fill")
                     .foregroundStyle(.green)
             )
 
-        case .syncing(_, _, _), .fullSyncing(_):
-            return AnyView(
+        case .syncing:
+            AnyView(
                 Image(systemName: "slowmo")
                     .symbolEffect(
                         .variableColor.cumulative
                     )
             )
 
         case .notStarted:
-            return AnyView(
+            AnyView(
                 Image(systemName: "arrow.clockwise")
             )
         default:
-            return AnyView(
+            AnyView(
                 Image(
                     systemName: "person.crop.circle.badge.exclamationmark"
                 )

BDKSwiftExampleWallet/View/WalletView.swift

@@ -185,28 +185,6 @@ struct WalletView: View {
     }
 }
 
-fileprivate extension WalletViewModel {
-    
-    var activityHeaderStateSync: ActivityHomeHeaderView.State {
-        let walletSyncState = walletSyncState
-        let needsFullScan = bdkClient.needsFullScan()
-        
-        if needsFullScan {
-            return .fullSyncing(inspectedScripts: inspectedScripts)
-        } else if walletSyncState == .synced {
-            return .synced
-        } else if walletSyncState == .syncing {
-            return .syncing(
-                progress: progress,
-                inspectedScripts: inspectedScripts,
-                totalScripts: totalScripts
-            )
-        } else {
-            return .notStarted
-        }
-    }
-}
-
 #if DEBUG
     #Preview("WalletView - en") {
         WalletView(