Conversation
|
Testing this seemed to work just fine so far |
Ran into one weird bug (might have been intro'd in bip84 pr?) but tried to fix with ee90b03 , and all the little commits from there on are making sure cut down code with no regressions Bug: Delete wallet -> kill app -> re-run app and switch bip address ... would do nothing on "create wallet" |
r1b2ns
left a comment
There was a problem hiding this comment.
ACK
Great improvement. I really liked it! 🔥
alright good to know it aligns close enough with the good work you did in #296 ! I'll keep testing this weird bug that may or may not be related to this PR, and then hopefully merge this week, and then can keep building on top of this by adding Kyoto etc |
Description
Abstracting client into its own type (in hopes of adding additional client types as PR's on top of this)
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
.swift-formatfileNew Features:
Bugfixes: