feat(client): Add v29 module

Author: tvpeter

Cargo.toml

@@ -18,4 +18,5 @@ jsonrpc = { version = "0.18.0", features = ["simple_http", "simple_tcp", "minreq
 [features]
 default = ["30_0"]
 30_0 = []
+29_0 = []
 28_0 = []

src/client.rs

@@ -6,11 +6,13 @@ use std::{
 
 use crate::error::Error;
 use crate::jsonrpc::minreq_http::Builder;
+#[cfg(not(feature = "29_0"))]
+use corepc_types::v30::GetBlockFilter;
 use corepc_types::{
     bitcoin::{
         block::Header, consensus::encode::deserialize_hex, Block, BlockHash, Transaction, Txid,
     },
-    model::{GetBlockCount, GetBlockFilter, GetRawMempool},
+    model::{GetBlockCount, GetRawMempool},
 };
 use jsonrpc::{
     serde,
@@ -21,6 +23,9 @@ use jsonrpc::{
 #[cfg(feature = "28_0")]
 pub mod v28;
 
+#[cfg(feature = "29_0")]
+pub mod v29;
+
 /// Client authentication methods for the Bitcoin Core JSON-RPC server
 #[derive(Clone, Debug, Hash, Eq, PartialEq, Ord, PartialOrd)]
 pub enum Auth {
@@ -187,7 +192,7 @@ impl Client {
         Ok(block_hash.parse()?)
     }
 
-    /// Retrieves the compact block filter for a given block
+    /// Retrieve the `basic` BIP 157 content filter for a particular block
     ///
     /// # Arguments
     ///
@@ -196,6 +201,7 @@ impl Client {
     /// # Returns
     ///
     /// The `GetBlockFilter` structure containing the filter data
+    #[cfg(not(feature = "29_0"))]
     pub fn get_block_filter(&self, block_hash: &BlockHash) -> Result<GetBlockFilter, Error> {
         let block_filter: GetBlockFilter = self.call("getblockfilter", &[json!(block_hash)])?;
         Ok(block_filter)

src/client/v29.rs

@@ -0,0 +1,21 @@
+use corepc_types::{bitcoin::BlockHash, v29::GetBlockFilter};
+
+use jsonrpc::serde_json::json;
+
+use crate::{Client, Error};
+
+impl Client {
+    /// Retrieve the `basic` BIP 157 content filter for a particular block
+    ///
+    /// # Arguments
+    ///
+    /// * `block_hash`: The hash of the block whose filter is requested
+    ///
+    /// # Returns
+    ///
+    /// The `GetBlockFilter` structure containing the filter data
+    pub fn get_block_filter(&self, block_hash: &BlockHash) -> Result<GetBlockFilter, Error> {
+        let block_filter: GetBlockFilter = self.call("getblockfilter", &[json!(block_hash)])?;
+        Ok(block_filter)
+    }
+}

tests/test_rpc_client.rs

@@ -169,11 +169,10 @@ fn test_get_block_hash_invalid_height() {
 fn test_get_best_block_hash() {
     let client = test_client();
 
-    let best_hash = client
+    let best_block_hash = client
         .get_best_block_hash()
         .expect("failed to get best block hash");
-
-    assert_eq!(best_hash.to_string().len(), 64);
+    assert_eq!(best_block_hash.to_string().len(), 64);
 }
 
 #[test]