Merge #183: chore(cbf): set kyoto client data dir

afc2f9d chore(cbf): mv kyoto data to existing datadir (Vihiga Tyonum)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  This PR set the data directory for the Kyoto client. See [comment](#181 (comment))

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  This PR ensures that the `light_client_data` directory created by the Kyoto client is in the wallet's data directory.

  ## Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature
  * [ ] I've updated `CHANGELOG.md`

ACKs for top commit:
  notmandatory:
    tACK afc2f9d

Tree-SHA512: 899e060313fc3a4263d52a242e785ae30e4e15c6172fcfc1b5242f1038c1670f568f1e09d8080944c9a2912a04ca2971ba1eda21eb0ef53bbff01d037dc02bdf

Author: notmandatory

src/handlers.rs

@@ -697,7 +697,8 @@ pub(crate) async fn handle_command(cli_opts: CliOpts) -> Result<String, Error> {
                 };
 
                 let mut wallet = new_persisted_wallet(network, &mut persister, &wallet_opts)?;
-                let blockchain_client = new_blockchain_client(&wallet_opts, &wallet)?;
+                let blockchain_client =
+                    new_blockchain_client(&wallet_opts, &wallet, Some(database_path))?;
 
                 let result = handle_online_wallet_subcommand(
                     &mut wallet,
@@ -773,7 +774,7 @@ pub(crate) async fn handle_command(cli_opts: CliOpts) -> Result<String, Error> {
             let (mut wallet, mut persister) = {
                 let wallet_name = &wallet_opts.wallet;
 
-                let home_dir = prepare_home_dir(cli_opts.datadir)?;
+                let home_dir = prepare_home_dir(cli_opts.datadir.clone())?;
 
                 let database_path = prepare_wallet_db_dir(wallet_name, &home_dir)?;
 
@@ -791,6 +792,8 @@ pub(crate) async fn handle_command(cli_opts: CliOpts) -> Result<String, Error> {
             };
             #[cfg(not(any(feature = "sqlite")))]
             let mut wallet = new_wallet(network, &wallet_opts)?;
+            let home_dir = prepare_home_dir(cli_opts.datadir.clone())?;
+            let database_path = prepare_wallet_db_dir(&wallet_opts.wallet, &home_dir)?;
 
             loop {
                 let line = readline()?;
@@ -799,7 +802,14 @@ pub(crate) async fn handle_command(cli_opts: CliOpts) -> Result<String, Error> {
                     continue;
                 }
 
-                let result = respond(network, &mut wallet, &wallet_opts, line).await;
+                let result = respond(
+                    network,
+                    &mut wallet,
+                    &wallet_opts,
+                    line,
+                    Some(database_path.clone()),
+                )
+                .await;
                 #[cfg(feature = "sqlite")]
                 wallet.persist(&mut persister)?;
 
@@ -830,6 +840,7 @@ async fn respond(
     wallet: &mut Wallet,
     wallet_opts: &WalletOpts,
     line: &str,
+    _datadir: Option<std::path::PathBuf>,
 ) -> Result<bool, String> {
     use clap::Parser;
 
@@ -846,7 +857,7 @@ async fn respond(
             subcommand: WalletSubCommand::OnlineWalletSubCommand(online_subcommand),
         } => {
             let blockchain =
-                new_blockchain_client(wallet_opts, &wallet).map_err(|e| e.to_string())?;
+                new_blockchain_client(wallet_opts, &wallet, _datadir).map_err(|e| e.to_string())?;
             let value = handle_online_wallet_subcommand(wallet, blockchain, online_subcommand)
                 .await
                 .map_err(|e| e.to_string())?;

src/utils.rs

@@ -154,6 +154,7 @@ pub(crate) enum BlockchainClient {
 pub(crate) fn new_blockchain_client(
     wallet_opts: &WalletOpts,
     wallet: &Wallet,
+    datadir: Option<std::path::PathBuf>,
 ) -> Result<BlockchainClient, Error> {
     #[cfg(any(feature = "electrum", feature = "esplora", feature = "rpc"))]
     let url = wallet_opts.url.as_str();
@@ -199,7 +200,12 @@ pub(crate) fn new_blockchain_client(
                 None => Sync,
             };
 
-            let client = NodeBuilder::new(wallet.network())
+            let mut builder = NodeBuilder::new(wallet.network());
+
+            if let Some(datadir) = datadir {
+                builder = builder.data_dir(&datadir);
+            };
+            let client = builder
                 .required_peers(wallet_opts.compactfilter_opts.conn_count)
                 .build_with_wallet(wallet, scan_type)?;