Skip to content

Commit a968341

Browse files
committed
Merge #125: Remove cbf
162aa9e Update cargo lock (rajarshimaitra) 9bbe768 disable also in CI (rajarshimaitra) 1175061 Temporarily Disable CBF (rajarshimaitra) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description Fixes #112 Removes compact block filters temporarily. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: notmandatory: ACK 162aa9e Tree-SHA512: 9a7b88a32c2e7fffd18eea477cfb49f05b5af523ed7811ab1f22d597736fee23b8baa30b0ec0fb0ddb54f6aa6fd7c5d5666e101b4fa4d0efecbb432cfa80b44b
2 parents 18ee6b2 + 162aa9e commit a968341

File tree

4 files changed

+8
-136
lines changed

4 files changed

+8
-136
lines changed

.github/workflows/code_coverage.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,9 @@ jobs:
3838
- name: Test Esplora-reqwest
3939
run: cargo test --features esplora-reqwest
4040

41-
- name: Test Compact Filters
42-
run: cargo test --features compact_filters
41+
# Temporarily disable compact filters
42+
#- name: Test Compact Filters
43+
# run: cargo test --features compact_filters
4344

4445
- name: Test RPC
4546
run: cargo test --features rpc

.github/workflows/cont_integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- esplora-ureq,sqlite-db
2121
- esplora-reqwest,sqlite-db
2222
- compiler,sqlite-db
23-
- compact_filters,sqlite-db
23+
#- compact_filters,sqlite-db # Compact Filters temporarily disabled
2424
- rpc,sqlite-db
2525
- reserves,electrum,sqlite-db
2626
- electrum,verify,sqlite-db

Cargo.lock

Lines changed: 0 additions & 132 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,15 @@ sqlite-db = ["bdk/sqlite"]
5757
# Available blockchain client options
5858
rpc = ["bdk/rpc"]
5959
electrum = ["bdk/electrum"]
60-
compact_filters = ["bdk/compact_filters"]
6160
esplora = []
6261
esplora-ureq = ["esplora", "bdk/use-esplora-ureq"]
6362
async-interface = ["bdk/async-interface"]
6463
esplora-reqwest = ["esplora", "bdk/use-esplora-reqwest", "bdk/reqwest-default-tls", "async-interface"]
6564

65+
# Compact Filters are temporarily diabled to avoid rockdb vulnerability.
66+
# Ref: https://github.com/bitcoindevkit/bdk-cli/issues/112
67+
#compact_filters = ["bdk/compact_filters"]
68+
6669
# Use this to consensus verify transactions at sync time
6770
verify = ["bdk/verify"]
6871

0 commit comments

Comments
 (0)