CI: Fix clippy issues

Author: tvpeter

Justfile

@@ -27,11 +27,8 @@ test:
 
 # checks before pushing
 pre-push:
-    cargo build --features default
     cargo test --features default
-    cargo build --no-default-features
     cargo test --no-default-features
-    cargo build --all-features
     cargo test --all-features
     cargo clippy --no-default-features --all-targets -- -D warnings
     cargo clippy --all-features --all-targets -- -D warnings

src/handlers.rs

@@ -1156,6 +1156,7 @@ pub fn handle_wallets_subcommand(datadir: &Path, pretty: bool) -> Result<String,
             .wallets
             .iter()
             .map(|(name, wallet_config)| {
+                #[allow(unused_mut)]
                 let mut wallet_json = json!({
                     "name": name,
                     "network": wallet_config.network,

src/payjoin/mod.rs

@@ -608,16 +608,12 @@ impl<'a> PayjoinManager<'a> {
                                         return Err(ImplementationError::from("Cannot find the transaction in the mempool or the blockchain"));
                                     };
 
-                                    let is_seen = match tx_details.chain_position {
-                                        bdk_wallet::chain::ChainPosition::Confirmed { .. } => true,
-                                        bdk_wallet::chain::ChainPosition::Unconfirmed { first_seen: Some(_), .. } => true,
-                                        _ => false
-                                    };
+                                    let is_seen = matches!(tx_details.chain_position, bdk_wallet::chain::ChainPosition::Confirmed { .. } | bdk_wallet::chain::ChainPosition::Unconfirmed { first_seen: Some(_), .. });
 
                                     if is_seen {
                                         return Ok(Some(tx_details.tx.as_ref().clone()));
                                     }
-                                    return Err(ImplementationError::from("Cannot find the transaction in the mempool or the blockchain"));
+                                Err(ImplementationError::from("Cannot find the transaction in the mempool or the blockchain"))
                                 },
                                 |outpoint| {
                                     let utxo = self.wallet.get_utxo(outpoint);

src/utils.rs

@@ -158,7 +158,7 @@ pub(crate) enum BlockchainClient {
     },
 
     #[cfg(feature = "cbf")]
-    KyotoClient { client: KyotoClientHandle },
+    KyotoClient { client: Box<KyotoClientHandle> },
 }
 
 /// Handle for the Kyoto client after the node has been started.
@@ -195,7 +195,7 @@ pub(crate) fn new_blockchain_client(
         }
         #[cfg(feature = "esplora")]
         ClientType::Esplora => {
-            let client = bdk_esplora::esplora_client::Builder::new(&url).build_async()?;
+            let client = bdk_esplora::esplora_client::Builder::new(url).build_async()?;
             BlockchainClient::Esplora {
                 client: Box::new(client),
                 parallel_requests: wallet_opts.parallel_requests,
@@ -245,10 +245,10 @@ pub(crate) fn new_blockchain_client(
             );
 
             BlockchainClient::KyotoClient {
-                client: KyotoClientHandle {
+                client: Box::new(KyotoClientHandle {
                     requester,
                     update_subscriber: tokio::sync::Mutex::new(update_subscriber),
-                },
+                }),
             }
         }
     };