test: add more tests for createtx, bip322

- add tests for OP_RETURN in createtx
- add tests for coin selection in createtx
- add test for esplora client full_scan
- fix clippy issues

Author: tvpeter

src/handlers/config.rs

@@ -12,7 +12,7 @@ use crate::config::{WalletConfig, WalletConfigInner};
 use crate::error::BDKCliError as Error;
 use crate::handlers::Init;
 use crate::handlers::{AppCommand, AppContext};
-#[cfg(feature = "sqlite")]
+#[cfg(any(feature = "sqlite", feature = "redb"))]
 use crate::persister::DatabaseType;
 use crate::utils::types::{StatusResult, WalletsListResult};
 use bdk_wallet::bitcoin::Network;

src/persister.rs

@@ -4,8 +4,10 @@ use bdk_wallet::Wallet;
 use bdk_wallet::bitcoin::Network;
 #[cfg(any(feature = "sqlite", feature = "redb"))]
 use bdk_wallet::{KeychainKind, PersistedWallet, WalletPersister};
+#[cfg(any(feature = "sqlite", feature = "redb"))]
 use clap::ValueEnum;
 
+#[cfg(any(feature = "sqlite", feature = "redb"))]
 #[derive(Clone, ValueEnum, Debug, Eq, PartialEq)]
 pub enum DatabaseType {
     /// Sqlite database

src/utils/runtime.rs

@@ -89,31 +89,28 @@ impl WalletRuntime {
         })
     }
 
-    pub fn build_wallet(&self, require_db: bool) -> Result<RuntimeWallet, Error> {
-        if !require_db {
-            return Ok(RuntimeWallet::Standard(Box::new(new_wallet(
-                self.network,
-                &self.wallet_opts,
-            )?)));
-        }
-
+    pub fn build_wallet(
+        &self,
+        #[cfg_attr(
+            not(any(feature = "sqlite", feature = "redb")),
+            allow(unused_variables)
+        )]
+        require_db: bool,
+    ) -> Result<RuntimeWallet, Error> {
         #[cfg(any(feature = "sqlite", feature = "redb"))]
-        {
+        if require_db {
             let mut persister = self.create_persister()?;
             let wallet = new_persisted_wallet(self.network, &mut persister, &self.wallet_opts)?;
-            Ok(RuntimeWallet::Persisted(
+            return Ok(RuntimeWallet::Persisted(
                 Box::new(wallet),
                 Box::new(persister),
-            ))
+            ));
         }
 
-        #[cfg(not(any(feature = "sqlite", feature = "redb")))]
-        {
-            Ok(RuntimeWallet::Standard(Box::new(new_wallet(
-                self.network,
-                &self.wallet_opts,
-            )?)))
-        }
+        Ok(RuntimeWallet::Standard(Box::new(new_wallet(
+            self.network,
+            &self.wallet_opts,
+        )?)))
     }
 
     #[cfg(any(