feat: scaffold transaction presentation in bdk_demo active wallet flow by j-kon · Pull Request #62 · bitcoindevkit/bdk-dart

j-kon · 2026-03-23T09:12:17Z

Summary

Adds a transaction detail flow to the reference wallet scaffold.

What changed

enabled navigation from transaction list to a transaction detail page
added TransactionDetailPage to display:
- full txid
- amount
- status
- block height
- timestamp
introduced WalletService.loadTransactionByTxid
made transaction rows tappable using Material/InkWell
refactored widget tests with FakeWalletService
added tests for:
- navigation to detail page
- correct transaction rendering
- handling missing transactions gracefully

Notes

uses placeholder transaction data
structured for future real wallet/BDK integration

reez · 2026-03-23T13:27:21Z

@Johnosezele cc

reez · 2026-03-24T15:23:50Z

Nice improvement to the demo flow and the widget coverage is solid.

I found one correctness issue before approval: TransactionDetailPage caches its future in initState, but go_router keys matched pages by the route pattern, so changing /transactions/:txid can reuse the same State and leave the screen showing the old transaction. Once that lifecycle case is handled, this is looking pretty good to merge.

j-kon · 2026-03-24T15:47:26Z

Nice improvement to the demo flow and the widget coverage is solid.

I found one correctness issue before approval: TransactionDetailPage caches its future in initState, but go_router keys matched pages by the route pattern, so changing /transactions/:txid can reuse the same State and leave the screen showing the old transaction. Once that lifecycle case is handled, this is looking pretty good to merge.

Good catch, that makes sense.

I’ll update the page to handle route changes properly instead of caching in initState.

…tests

j-kon · 2026-03-24T17:47:25Z

Good catch on that — makes sense.

I’ve fixed it by refreshing the cached future in didUpdateWidget whenever the txid changes, so the page no longer shows stale transaction data when the route is reused.

Also added a widget test to cover this exact case (same page instance, different txid).

Everything’s passing on my end. Happy to adjust if you prefer a different approach.

CC @reez

Johnosezele

Thanks for taking this on! Great changes in the UI side of things.

I recognize this as a scaffold pr but I think there's some mixup from the ground up

You're not fetching transaction details from CanonicalTx of bdk.dart where sent/received come from wallet.sentAndReceived().

For your changes on the wallet_service.dart file, you are mostly return hardcoded placeholder data, you're not making use of our bdk.dart bindings api, I can't see any of the related methods, can you take a look at this commit. By extension this has a huge impact on wallet_providers.dart

For the test section of your PR, We'd need to structure /bdk_demo/test because as our test suite grows things may begin to look tightly coupled, part of what I did in the /test section of this commit which is still draft.

@reez pls can you hold off on merging this just yet, there seem to be alot of parallel implementation conflict as this is a scaffold pr, it would need to be rebased due to lots of conflicting changes with [this](https://github.com/bitcoindevkit/bdk-dart/pull/61)

Johnosezele · 2026-03-24T15:58:11Z

bdk_demo/README.md

 # BDK-Dart Wallet (Flutter)

-The _BDK-Dart Wallet_ is a wallet built as a reference app for the [bitcoindevkit](https://github.com/bitcoindevkit) on Flutter using [bdk-dart](https://github.com/bitcoindevkit/bdk-dart). This repository is not intended to produce a production-ready wallet, the app only works on Signet, Testnet 3, and Regtest.
+The _BDK-Dart Wallet_ is a Flutter reference app for [bitcoindevkit](https://github.com/bitcoindevkit) using [bdk-dart](https://github.com/bitcoindevkit/bdk-dart). It is intentionally a demo and scaffold, not a production-ready wallet, and currently targets Signet, Testnet 3, and Regtest.


I see some change in description here that may not be related to this pr, is this intentional?

Johnosezele · 2026-03-24T15:59:15Z

bdk_demo/README.md

 The demo app is built with the following goals in mind:
 1. Be a reference application for the `bdk_dart` API on Flutter (iOS & Android).
-2. Showcase the core features of the bitcoindevkit library: wallet creation, recovery, Esplora/Electrum sync, send, receive, and transaction history.
+2. Sketch the wallet creation, recovery, sync, send, receive, and transaction-history flows the app can grow into over time.


same here as my comment above, if you can maybe add readme update as a separate commit.

Johnosezele · 2026-03-24T16:34:05Z

bdk_demo/lib/features/wallet_setup/transaction_detail_page.dart

+class _TransactionDetailPageState extends ConsumerState<TransactionDetailPage> {
+  late final Future<TxDetails?> _transactionFuture;
+
+  @override
+  void initState() {
+    super.initState();
+    _transactionFuture = ref
+        .read(walletServiceProvider)
+        .loadTransactionByTxid(widget.txid);
+  }


_transactionFuture is cached in initState as late final. If go_router reuses the same state object with a different txid (which happens when navigating between /transactions/:txid1 and /transactions/:txid2), the page will show stale data.

Johnosezele · 2026-03-24T16:48:34Z

bdk_demo/lib/features/wallet_setup/active_wallets_page.dart

Could you consider moving shared helper widgets (_InfoCard, _LoadingCard, _DetailRow, _StatusChip) to features/shared/widgets/ since similar widgets are duplicated in transaction_detail_page.dart too.

_StatusChip and _DetailRow are defined almost identically in both active_wallets_page.dart and transaction_detail_page.dart. Can you extract them to a shared location.

Johnosezele · 2026-03-24T16:54:25Z

bdk_demo/lib/models/tx_details.dart

+  String get shortTxid => txid.length > 10
+      ? '${txid.substring(0, 6)}...${txid.substring(txid.length - 4)}'


can you make shortTxid delegate to Formatters.abbreviateTxid(txid) or remove one, they are two impl of same logic.

Johnosezele · 2026-03-24T16:59:17Z

bdk_demo/lib/features/wallet_setup/transaction_detail_page.dart

+        .read(walletServiceProvider)
+        .loadTransactionByTxid(widget.txid);
+  }
+


consider adding test verifying that navigating from one transaction to another correctly refreshes the detail page.

Johnosezele · 2026-03-24T17:06:15Z

bdk_demo/lib/features/wallet_setup/active_wallets_page.dart

+      return;
+    }
+
+    await Future<void>.delayed(Duration.zero);


nit: could this be removed? Is there a specific reason for it?

j-kon · 2026-03-25T00:54:01Z

Thanks a lot for the detailed review — this really helps.

I see what you mean about the mixup with using placeholder data instead of wiring through the bdk.dart APIs, and also the structure concerns around the demo/tests.

I’ll take a step back and align this properly with the existing architecture, rework the service layer to use CanonicalTx / wallet APIs, and clean up the structure as suggested.

Also noted on the README and shared widgets — I’ll split those changes out and refactor accordingly.

Appreciate the guidance here 🙏

reez · 2026-04-07T14:46:50Z

merged #61 so can rebase this branch

j-kon added 2 commits March 23, 2026 10:03

feat: scaffold transaction presentation in bdk_demo active wallet flow

96dbdf7

feat: add transaction detail flow with navigation and tests

a7798fd

feat: enhance transaction detail page to refresh on txid change with …

2d3e933

…tests

Johnosezele suggested changes Mar 24, 2026

View reviewed changes

		String get shortTxid => txid.length > 10
		? '${txid.substring(0, 6)}...${txid.substring(txid.length - 4)}'

Conversation

j-kon commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Notes

Uh oh!

reez commented Mar 23, 2026

Uh oh!

reez commented Mar 24, 2026

Uh oh!

j-kon commented Mar 24, 2026

Uh oh!

j-kon commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Johnosezele left a comment

Choose a reason for hiding this comment

Uh oh!

Johnosezele Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Johnosezele Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Johnosezele Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Johnosezele Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Johnosezele Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Johnosezele Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Johnosezele Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

j-kon commented Mar 25, 2026

Uh oh!

reez commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

j-kon commented Mar 23, 2026 •

edited

Loading

j-kon commented Mar 24, 2026 •

edited

Loading