feat: bump bdk_wallet to 3.1.0#1030
Conversation
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
This will take some time to review, but I'm adding some questions here!
| /// Also looks at the corresponding descriptor to determine the `SignerContext` to attach to | ||
| /// the signers. | ||
| #[uniffi::constructor] | ||
| pub fn from_descriptor_with_context( |
There was a problem hiding this comment.
I'd like to make sure I understand well the use case(s) for this constructor. Can we add a test showcasing this?
|
|
||
| /// Returns the number of signers in the container. | ||
| pub fn len(&self) -> u64 { | ||
| self.inner.signers().len() as u64 |
There was a problem hiding this comment.
What does this length represent? A reminder to myself to look into it.
| /// extracts keys from the provided descriptor while loading. | ||
| #[uniffi::constructor(default(lookahead = 25))] | ||
| pub fn load_from_two_path_descriptor( | ||
| two_path_descriptor: Arc<Descriptor>, |
There was a problem hiding this comment.
I added a PR on bdk_wallet bitcoindevkit/bdk_wallet#506 to fix the docs on this, and it indeed requires public descriptors to work. We should just pull that in here as well, and fix up the API docs to on the create_from_two_path_descriptor method to also copy what is now in the Rust API docs (old PR of mine too back then).
In our case the failure happens earlier than in the constructor however, since the user can't pass a string to the constructor and passes a full Descriptor type, which simply cannot be built using private+multipath (see our test for this on bdk-jvm here), so the user would never really get to the constuctor in the first place with their private multipath descriptor. Still I'd like to see the docs mention it here if possible (even though my PR 506 is not merged yet).
2 participants
Description
Dependency bump. The other commits are more experimental to see the shape of exposing new APIs.
Notes to the reviewers
Documentation
bdk_walletbitcoinuniffiChangelog
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingchangelog:*labelNew Features:
Bugfixes: