Skip to content

feat!: expose chainposition first and last seen timestamps#1039

Open
reez wants to merge 1 commit into
bitcoindevkit:masterfrom
reez:firstseen
Open

feat!: expose chainposition first and last seen timestamps#1039
reez wants to merge 1 commit into
bitcoindevkit:masterfrom
reez:firstseen

Conversation

@reez

@reez reez commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Description

Exposes upstream ChainPosition::Unconfirmed first_seen and last_seen fields instead of collapsing them into a single timestamp.

Breaking: ChainPosition::Unconfirmed.timestamp is replaced by first_seen and last_seen. The previous timestamp value corresponds to last_seen.

Notes to the reviewers

Follow-up from #1032 review discussion.

Documentation

Changelog

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added exactly one changelog:* label
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@ItoroD ItoroD left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 15ab034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants