Testing the new potential kyoto client#965
Open
thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
Open
Testing the new potential kyoto client#965thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
thunderbiscuit
force-pushed
the
new-kyoto
branch
from
bcb9ca6 to
c0925a0
Compare
7 tasks
Collaborator
|
Do we know why CI is failing? |
Member
Author
reez
reviewed
Mar 9, 2026
| // println("Hello, Compact Block Filters!") | ||
| // val regtestEnv = RegEnv.connectTo(walletName = "faucet", username = "regtest", password = "password") | ||
|
|
||
| val wallet: Wallet = Wallet.createSingle( |
Collaborator
There was a problem hiding this comment.
Should this use a regtest descriptor here? wondering because from what I see BIP86_DESCRIPTOR is created with Network.TESTNET but the wallet is initialized with Network.REGTEST
reez
reviewed
Mar 9, 2026
| wallet.applyUpdate(update) | ||
|
|
||
| val balance = wallet.balance().total.toSat() | ||
| assert(balance > 0uL) |
Collaborator
There was a problem hiding this comment.
Should this use a real test assertion and reenable the funding/mine steps, I think the wallet is never funded and the final assert(...) may be skipped so the test can pass without validating Kyoto sync? Maybe im wrong though
reez
reviewed
Mar 9, 2026
Collaborator
reez
left a comment
reez
left a comment
There was a problem hiding this comment.
Looks good overall and consistent w bdk kyoto, a couple questions comments added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to connect the dots from bdk_kyoto all the way to the the bindings.
bitcoindevkit/bdk-kyoto#146