Skip to content

Commit 71ebdef

Browse files
committed
Merge #62: test: refresh BIP-352 test vectors to v1.1.1
bcac039 test: refresh BIP-352 test vectors to v1.1.1 (macgyver13) Pull request description: ### Description Refresh BIP-352 test vectors to match version [1.1.1](bitcoin/bips#2142) - Add tests 26 & 27 to send.rs and receive.rs. - Modify serialization to parse the updated sending.given.recipients map and maintain receiving.expected.addresses string format. ### Notes to the reviewers cargo t --test functional_tests bip352_vectors All tests pass - 3 are ignored for this PR ``` test bip352_vectors::send::input_keys_intermediate_sum_is_zero_but_final_sum_is_non_zero ... ignored, currently fails due to intermediate sum being zero test bip352_vectors::send::maximum_per_group_recipient_limit_k_max_is_exceeded ... ignored, limit k-max not implemented test bip352_vectors::receive::maximum_per_group_recipient_limit_k_max_is_exceeded ... ignored, limit k-max not implemented ``` Resolving ignored tests will be handled in future PRs. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [conventional commit guidelines](https://www.conventionalcommits.org/en/v1.0.0/) * [x] I ran `just p` (fmt, clippy and test) before committing ACKs for top commit: nymius: ACK bcac039 Tree-SHA512: ae04dfaec03e833605d2deb7262b168c0892484432f7ebc8263e3db46cdfd54e5d24b34da65de9fa69bc2c5f94d8de901d6dbba3271f8ef89d422ca25baff40c
2 parents be43061 + bcac039 commit 71ebdef

4 files changed

Lines changed: 3075 additions & 74 deletions

File tree

silentpayments/tests/functional_tests/bip352_vectors/receive.rs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,3 +267,14 @@ fn no_valid_inputs_sender_generates_no_outputs() {
267267
fn input_keys_sum_up_to_zero_point_at_infinity_sending_fails_receiver_skips_tx() {
268268
check_cases(25);
269269
}
270+
271+
#[test]
272+
fn input_keys_intermediate_sum_is_zero_but_final_sum_is_non_zero() {
273+
check_cases(26);
274+
}
275+
276+
#[test]
277+
#[ignore = "limit k-max not implemented"]
278+
fn maximum_per_group_recipient_limit_k_max_is_exceeded() {
279+
check_cases(27);
280+
}

silentpayments/tests/functional_tests/bip352_vectors/send.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,3 +175,15 @@ fn no_valid_inputs_sender_generates_no_outputs() {
175175
fn input_keys_sum_up_to_zero_point_at_infinity_sending_fails_receiver_skips_tx() {
176176
check_cases(25);
177177
}
178+
179+
#[test]
180+
#[ignore = "currently fails due to intermediate sum being zero"]
181+
fn input_keys_intermediate_sum_is_zero_but_final_sum_is_non_zero() {
182+
check_cases(26);
183+
}
184+
185+
#[test]
186+
#[ignore = "limit k-max not implemented"]
187+
fn maximum_per_group_recipient_limit_k_max_is_exceeded() {
188+
check_cases(27);
189+
}

0 commit comments

Comments
 (0)