I just saw the issue linked to an older bdk code_coverage.yml. I'll try to update. -> Done

Thank you @noahjoeris just noting that I think there are plans to switch to codecov-action for uploading coverage reports using BDK's CODECOV_TOKEN (bitcoindevkit/bdk#2144), maybe we can try that here?

Changed it to codecov. You might still need to set the codecov token tho :)

The token exists at the org level but maybe not activated for this repo yet. While I look into it here's some additional notes

• We can probably exclude unit/integration test modules from coverage as well
• I'm not sure what --doctests is doing and seems to have produced a warning but I didn't investigate
• It would be ideal to try cargo llvm-cov with a more recent version of the nightly compiler
• Unrelated, but we should also using caching in rust.yml which is made easy by actions-rust-lang/setup-rust-toolchain

Good points thx. I updated.

Ah I think merging to master is all that's needed for codecov.io.

Can we add this? ValuedMammal@8d2ea5b

Cool, I added it. Seems to work and exclude unit tests. Though I get this warn.

warning: feature `coverage_attribute` is declared but not used

cargo llvm-cov compiles the crate twice, once as the library (no cfg(test)), once as the test binary. In the library pass, #[cfg(test)] mod tests is stripped before attribute checking, so rustc never sees #[coverage(off)] being used and flags the feature as unused. In the test pass it's seen and works as intended.

We probably don't want to just silence it with: #![cfg_attr(coverage_nightly, allow(unused_features))]. Can we live with that warning?

In the library pass, #[cfg(test)] mod tests is stripped before attribute checking, so rustc never sees #[coverage(off)] being used and flags the feature as unused.

I tried to reproduce the warning in bdk_wallet with no success. I suppose one fix could be to use coverage(off) for a non-test item like a Display impl.