Skip to content

Commit 47556ab

Browse files
committed
Merge #2006: refactor: replace examples with focused rustdoc examples
522e441 chore: Remove example_cli (Kyle 🐆) Pull request description: Closes #1973 The PR is now scoped to the first step of the work discussed in #1973: - Remove the unmaintained example binaries in examples/ - Remove the related workspace members from Cargo.toml - Clean up docs and CI references that pointed to the removed examples ACKs for top commit: ValuedMammal: ACK 522e441 Tree-SHA512: 217bbe23c0798903046eaf3f8638099d721c59bc26902fa5d9c3a0e3c3bcc6738b9a7e9b6e6ca82e3c1758aaffd69bec3e91cf00e5a6bf7e1da7c53cf23f1288
2 parents f9ea5e1 + 522e441 commit 47556ab

14 files changed

Lines changed: 2 additions & 2122 deletions

File tree

.github/workflows/cont_integration.yml

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ jobs:
4949
env:
5050
MATRIX_RUST_VERSION: ${{ matrix.rust.version }}
5151
run: |
52-
cargo build --workspace --exclude 'example_*' ${{ matrix.features }}
53-
cargo test --workspace --exclude 'example_*' ${{ matrix.features }}
52+
cargo build --workspace ${{ matrix.features }}
53+
cargo test --workspace ${{ matrix.features }}
5454
5555
check-no-std:
5656
needs: prepare
@@ -141,32 +141,6 @@ jobs:
141141
- name: Clippy
142142
run: cargo clippy --all-features --all-targets -- -D warnings
143143

144-
build-examples:
145-
needs: prepare
146-
name: Build & Test Examples
147-
runs-on: ubuntu-latest
148-
strategy:
149-
matrix:
150-
example-dir:
151-
- example_cli
152-
- example_bitcoind_rpc_polling
153-
- example_electrum
154-
- example_esplora
155-
steps:
156-
- name: checkout
157-
uses: actions/checkout@v6
158-
with:
159-
persist-credentials: false
160-
- name: Install Rust toolchain
161-
uses: actions-rust-lang/setup-rust-toolchain@v1
162-
with:
163-
toolchain: ${{ needs.prepare.outputs.rust_version }}
164-
override: true
165-
cache: true
166-
- name: Build
167-
working-directory: examples/${{ matrix.example-dir }}
168-
run: cargo build
169-
170144
check-docs:
171145
needs: prepare
172146
name: Check documentation errors

Cargo.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ members = [
88
"crates/esplora",
99
"crates/bitcoind_rpc",
1010
"crates/testenv",
11-
"examples/example_cli",
12-
"examples/example_electrum",
13-
"examples/example_esplora",
14-
"examples/example_bitcoind_rpc_polling",
1511
]
1612

1713
[workspace.package]

README.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,6 @@ The workspace in this repository contains several crates in the `/crates` direct
4141

4242
The [`bdk_wallet`] repository and crate contains a higher level `Wallet` type that depends on the above lower-level mechanism crates.
4343

44-
Fully working examples of how to use these components are in `/examples`:
45-
46-
- [`example_cli`](examples/example_cli): Library used by the `example_*` crates. Provides utilities for syncing, showing the balance, generating addresses and creating transactions without using the bdk_wallet `Wallet`.
47-
- [`example_electrum`](examples/example_electrum): A command line Bitcoin wallet application built on top of `example_cli` and the `electrum` crate. It shows the power of the bdk tools (`chain` + `file_store` + `electrum`), without depending on the main `bdk_wallet` library.
48-
- [`example_esplora`](examples/example_esplora): A command line Bitcoin wallet application built on top of `example_cli` and the `esplora` crate. It shows the power of the bdk tools (`chain` + `file_store` + `esplora`), without depending on the main `bdk_wallet` library.
49-
- [`example_bitcoind_rpc_polling`](examples/example_bitcoind_rpc_polling): A command line Bitcoin wallet application built on top of `example_cli` and the `bitcoind_rpc` crate. It shows the power of the bdk tools (`chain` + `file_store` + `bitcoind_rpc`), without depending on the main `bdk_wallet` library.
50-
5144
[`rust-miniscript`]: https://github.com/rust-bitcoin/rust-miniscript
5245
[`rust-bitcoin`]: https://github.com/rust-bitcoin/rust-bitcoin
5346
[`esplora-client`]: https://docs.rs/esplora-client/

crates/electrum/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
//! where the range of possibly used scripts is not known. In this case it is necessary to scan all
1212
//! keychain scripts until a number (the "stop gap") of unused scripts is discovered.
1313
//!
14-
//! Refer to [`example_electrum`] for a complete example.
15-
//!
16-
//! [`example_electrum`]: https://github.com/bitcoindevkit/bdk/tree/master/examples/example_electrum
1714
//! [`SyncResponse`]: bdk_core::spk_client::SyncResponse
1815
//! [`FullScanResponse`]: bdk_core::spk_client::FullScanResponse
1916
#![cfg_attr(coverage_nightly, feature(coverage_attribute))]

crates/esplora/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ use bdk_esplora::EsploraExt;
4141
use bdk_esplora::EsploraAsyncExt;
4242
```
4343

44-
For full examples, refer to [`example_wallet_esplora_blocking`](https://github.com/bitcoindevkit/bdk/tree/master/examples/example_wallet_esplora_blocking) and [`example_wallet_esplora_async`](https://github.com/bitcoindevkit/bdk/tree/master/examples/example_wallet_esplora_async).
45-
4644
[`esplora-client`]: https://docs.rs/esplora-client/
4745
[`bdk_chain`]: https://docs.rs/bdk-chain/
4846
[`EsploraExt`]: crate::EsploraExt

examples/example_bitcoind_rpc_polling/Cargo.toml

Lines changed: 0 additions & 12 deletions
This file was deleted.

examples/example_bitcoind_rpc_polling/README.md

Lines changed: 0 additions & 67 deletions
This file was deleted.

0 commit comments

Comments
 (0)