Merge #2170: fix(chain): add missing continue in CanonicalIter assumed-tx processing

27ab7ee fix(chain): add missing `continue` in `CanonicalIter` assumed-tx processing (Elias Rohrer)
c4c87c5 ci: pin `hyper-rustls` to 0.27.7 for 1.75.0 toolchain (valued mammal)

Pull request description:

  ### Description
  Without the `continue`, the loop falls through to the subsequent processing blocks when assumed-canonical transactions are the only remaining unprocessed source. If the anchored, seen, and leftover iterators are all exhausted, the loop reaches `return None` and silently drops the assumed transactions that were just marked canonical.

  ### Notes to the reviewers

  Co-Authored-By: HAL 9000

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 27ab7ee

Tree-SHA512: 9d06d6b254c51144b174d61859cc6e5b5f8b803324925e2091c4ac438b3dd86d2a9c8312ace8785d4c1d04f533869c2036b2999f02f886c05bff698e6a582a14

Author: ValuedMammal

.github/workflows/cont_integration.yml

@@ -59,6 +59,7 @@ jobs:
           cargo update -p time --precise "0.3.41"
           cargo update -p proptest --precise "1.8.0"
           cargo update -p "getrandom@0.4.2" --precise "0.2.17"
+          cargo update -p "hyper-rustls" --precise "0.27.7"
       - name: Pin dependencies for MSRV
         if: matrix.rust.version == '1.63.0'
         run: ./ci/pin-msrv.sh

ci/pin-msrv.sh

@@ -29,7 +29,7 @@ cargo update -p base64ct --precise "1.6.0"
 cargo update -p minreq --precise "2.13.2"
 cargo update -p tracing --precise "0.1.40"
 cargo update -p tracing-core --precise "0.1.33"
-cargo update -p "webpki-roots@1.0.6" --precise "1.0.1"
+cargo update -p "webpki-roots@1.0.7" --precise "1.0.1"
 cargo update -p rayon --precise "1.10.0"
 cargo update -p rayon-core --precise "1.12.1"
 cargo update -p openssl --precise "0.10.73"
@@ -53,10 +53,12 @@ cargo update -p unicode-ident --precise "1.0.13"
 cargo update -p hyper-util --precise "0.1.6"
 cargo update -p pin-project --precise "1.1.5"
 cargo update -p pin-project-internal --precise "1.1.5"
-cargo update -p "rustls@0.23.37" --precise "0.23.26"
+cargo update -p "rustls@0.23.38" --precise "0.23.26"
+cargo update -p "libc" --precise "0.2.183"
+cargo update -p "semver" --precise "1.0.27"
 
 # all pinning required due to `clap` usage in `example_cli`
-cargo update -p "clap@4.6.0" --precise "4.5.17"
+cargo update -p "clap@4.6.1" --precise "4.5.17"
 cargo update -p proc-macro2 --precise "1.0.92"
 cargo update -p quote --precise "1.0.41"
 cargo update -p syn --precise "2.0.106"

crates/chain/src/canonical_iter.rs

@@ -218,6 +218,7 @@ impl<A: Anchor, C: ChainOracle> Iterator for CanonicalIter<'_, A, C> {
                 if !self.is_canonicalized(txid) {
                     self.mark_canonical(txid, tx, CanonicalReason::assumed());
                 }
+                continue;
             }
 
             if let Some((txid, tx, anchors)) = self.unprocessed_anchored_txs.next() {

crates/chain/tests/test_tx_graph_conflicts.rs

@@ -943,6 +943,34 @@ fn test_tx_conflict_handling() {
                 confirmed: Amount::ZERO,
             },
         },
+        Scenario {
+            name: "only assumed-canonical txs are yielded without anchored or seen txs",
+            tx_templates: &[
+                TxTemplate {
+                    tx_name: "assumed_a",
+                    inputs: &[TxInTemplate::Bogus],
+                    outputs: &[TxOutTemplate::new(21_000, Some(0))],
+                    assume_canonical: true,
+                    ..Default::default()
+                },
+                TxTemplate {
+                    tx_name: "assumed_b",
+                    inputs: &[TxInTemplate::Bogus],
+                    outputs: &[TxOutTemplate::new(18_000, Some(1))],
+                    assume_canonical: true,
+                    ..Default::default()
+                },
+            ],
+            exp_chain_txs: HashSet::from(["assumed_a", "assumed_b"]),
+            exp_chain_txouts: HashSet::from([("assumed_a", 0), ("assumed_b", 0)]),
+            exp_unspents: HashSet::from([("assumed_a", 0), ("assumed_b", 0)]),
+            exp_balance: Balance {
+                immature: Amount::ZERO,
+                trusted_pending: Amount::from_sat(21_000 + 18_000),
+                untrusted_pending: Amount::ZERO,
+                confirmed: Amount::ZERO,
+            },
+        },
         Scenario {
             name: "coinbase tx must not become unconfirmed",
             tx_templates: &[