refactor: move tx_template from bdk_chain to bdk_testenv#1800
Closed
tvpeter wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
refactor: move tx_template from bdk_chain to bdk_testenv#1800tvpeter wants to merge 1 commit intobitcoindevkit:masterfrom
tx_template from bdk_chain to bdk_testenv#1800tvpeter wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
3 times, most recently
from
8b81584 to
12181bb
Compare
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
from
12181bb to
13b87ac
Compare
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
from
13b87ac to
dd47a8b
Compare
Collaborator
There was a problem hiding this comment.
Thanks for working on this one, so far it's looking good.
Please update the commit messages to follow conventional commits, i.e: `refactor: move `tx_template` from `bdk_chain` to `bdk_testenv`
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
from
dd47a8b to
657ffd8
Compare
tvpeter
changed the title
tx_template from bdk_chain to bdk_testenv
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
from
657ffd8 to
1546ef6
Compare
Collaborator
|
You probably need a rebase to make sure CI is passing. |
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
2 times, most recently
from
7d8ec4b to
b42a074
Compare
- refactor tx_template struct and init_graph to use Cow pointer - move `tx_template` from `chain/tests/common` to `testenv/src` - update `chain/tests` files to use `tx_template` from `testenv` - update deps in `chain/cargo.toml` and `testenv/cargo.toml` - update imports in `testenv/src/lib.rs` - refactor canonical benchmarks in `chain/benches` to use tx_template [Ticket: 1754]
tvpeter
force-pushed
the
test/move-txtemplate-to-testenv
branch
from
b42a074 to
32cb79b
Compare
6 tasks
Collaborator
|
I've recently faced the issues of not having the @tvpeter this PR needs a big rebase. |
Collaborator
Author
|
I will be splitting this PR into two because there are several changes across the affected crates. It seems more challenging to rebase and catch up. Once I link the two new PRs, I will close this one. |
Collaborator
Author
|
Closing this PR in favour of #2177 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following changes:
TxTemplatefromcrates/chain/tests/common/mod.rstotestenv.init_graphfunction andTxTemplatestruct to useCowO(n)canonicalization algorithm #1670 using TxTemplatesCloses #1936
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing