fix(examples): make regtest default on wallet_example_rpc#1872
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Mar 7, 2025
Merged
Conversation
Collaborator
oleonardolima
left a comment
There was a problem hiding this comment.
cACK 710b9cc
I personally prefer to use regtest on the examples too, let's see what others think about it.
Also, you'd need a rebase to make sure that CI is running properly.
710b9cc to
8ed817e
Compare
notmandatory
approved these changes
Mar 6, 2025
Member
notmandatory
left a comment
There was a problem hiding this comment.
ACK 8ed817e
I agree, especially for the RPC client default network should be Regtest so user doesn't need to wait for testnet or mainnet IBD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
Regtestthe default network onwallet_example_rpcand updates the README accordingly.Notes to the reviewers
It had
Testnetas the default network,8332as the default port and481824as the starting height; now everything isRegtest.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing