Skip to content

chore: Fix typo in error message#1880

Closed
wzrdo wants to merge 1 commit intobitcoindevkit:masterfrom
wzrdo:patch-1
Closed

chore: Fix typo in error message#1880
wzrdo wants to merge 1 commit intobitcoindevkit:masterfrom
wzrdo:patch-1

Conversation

@wzrdo
Copy link
Copy Markdown

@wzrdo wzrdo commented Mar 8, 2025

Description

I noticed a typo in the error message where "atleast" was written as one word. This corrects it to "at least" for better readability and accuracy.


Here’s the corrected code snippet:

let &tip_height = latest_blocks
    .keys()
    .last()
    .expect("must have at least one entry");

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@YuriQueirozAndrade
Copy link
Copy Markdown

Hey @wzrdo,

It's great that you're trying to contribute to the BDK project! However, I don't think this typo fix is substantial enough to be merged at this time. I recommend checking out issue #1762 and the contributing guide. Addressing multiple typos in a single pull request or resolving issues with more substance, like fixing bugs or adding new features, would provide more value and increase the likelihood of your pull request being accepted.

@wzrdo
Copy link
Copy Markdown
Author

wzrdo commented Mar 11, 2025

Hey @wzrdo,

It's great that you're trying to contribute to the BDK project! However, I don't think this typo fix is substantial enough to be merged at this time. I recommend checking out issue #1762 and the contributing guide. Addressing multiple typos in a single pull request or resolving issues with more substance, like fixing bugs or adding new features, would provide more value and increase the likelihood of your pull request being accepted.

And I think that's quite enough. I've looked at the pull request history, you've even accepted a single corrected letter, so go ahead, get to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants