fix(wallet): no debug on Display implementations#1881
Closed
luisschwab wants to merge 5 commits intobitcoindevkit:masterfrom
Closed
fix(wallet): no debug on Display implementations#1881luisschwab wants to merge 5 commits intobitcoindevkit:masterfrom
luisschwab wants to merge 5 commits intobitcoindevkit:masterfrom
Conversation
110CodingP
reviewed
Mar 12, 2025
Contributor
|
Although this PR is scoped to the wallet, I was wondering if we should also remove the Debug outputs from Display implementations in keychain_txout.rs (line 798), tx_graph.rs (line 228), spk_client.rs (line 24), and file_store/src/lib.rs (line 25)? |
Member
Author
Yes, but those should go on different PRs. |
luisschwab
force-pushed
the
fix/no-debug-on-display-impls
branch
from
328e42f to
946d454
Compare
luisschwab
force-pushed
the
fix/no-debug-on-display-impls
branch
from
0536428 to
2f6642f
Compare
luisschwab
force-pushed
the
fix/no-debug-on-display-impls
branch
from
2f6642f to
a393147
Compare
luisschwab
force-pushed
the
fix/no-debug-on-display-impls
branch
from
a393147 to
32d470b
Compare
This was referenced Mar 31, 2025
Member
Author
|
@ValuedMammal I think this is RTM |
Member
Author
|
Closing this and moving to bitcoindevkit/bdk_wallet#12 |
3 tasks
evanlinjin
added a commit
that referenced
this pull request
Feb 7, 2026
823e4e9 fix(file_store)!: remove Debug usage and implement Display for StoreError. (Dmenec) 5a85f6e fix(chain)!: remove Debug usage and implement Display for CalculateFeeError (Dmenec) d0889f3 docs(core): add detailed SyncRequest output example (Dmenec) 5d715c2 fix(chain)!: remove Debug usage and implement Display for InsertDescriptorError (Dmenec) Pull request description: ### Description Fixes #1933, remove the usage of `Debug` on `Display` implemetations mentioned in #1881 (comment) ### Changelog notice - Replaced `Debug` usage with `Display` messages for `InsertDescriptorError`, `CalculateFeeError` and `StoreError`. - `InvalidMagicBytes` now displays expected and actual bytes in hexadecimal instead of using `Debug`. - Added a new `short_descriptor` function to shorten descriptors for concise error output. - Added detailed `SyncRequest` `Display` for Esplora and Electrum examples. ### Checklists #### All Submissions: * [x] I have signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `just check`, `just fmt` and `just test` before committing ACKs for top commit: evanlinjin: ACK 823e4e9 Tree-SHA512: fc3d66b72dc3f7ed3dee3b017687ece73c93883d23cbb019c402e55957368a6487e02b400b092169c326a47a86403f7aa865fe7d7238ccc6eb77afef258ec1ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1933.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing