ci: use ubuntu-latest on check-wasm#1885
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Mar 17, 2025
Merged
Conversation
luisschwab
force-pushed
the
ci/use-explicit-ubuntu-version
branch
from
85ae5af to
ed99cbf
Compare
3 tasks
ValuedMammal
added a commit
that referenced
this pull request
Mar 13, 2025
…MSRV a186f00 ci: pin `minreq` to `2.13.2` (Luis Schwab) 1a3b420 ci: pin `base64ct` to `1.6.0` (Luis Schwab) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description - Pin `minreq` to `2.13.2` because `2.13.3` uses the unstable `std::sync::LazyLock` (#1886 (comment)). - Pin `base64ct` to `1.6.0` for MSRV. Required for #1885 (`ubuntu-24.04` on all CI workflows). ### Checklists #### All Submissions: * [X] I've signed all my commits * [X] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [X] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: LagginTimes: ACK a186f00 ValuedMammal: ACK a186f00 Tree-SHA512: cfc78846c3225caa28bcd985bdec670ffccd564b6b8c4b9e9d6c8fdb3bf923005704118e994f1e211f8a52b7ddb34d9fe9b30d89a1d5254eca146f1720466e49
luisschwab
force-pushed
the
ci/use-explicit-ubuntu-version
branch
from
ed99cbf to
f467449
Compare
Collaborator
|
Honestly I'm fine with sticking with ubuntu-latest. It's still just the latest LTS right? so probably won't change very frequently. |
Member
Author
Yes, I guess it wouldn't be an immediate issue, there's still a year before the next LTS release. |
luisschwab
force-pushed
the
ci/use-explicit-ubuntu-version
branch
from
f467449 to
e3ef88f
Compare
luisschwab
changed the title
check-wasm
luisschwab
force-pushed
the
ci/use-explicit-ubuntu-version
branch
from
e3ef88f to
9710ecf
Compare
luisschwab
changed the title
check-wasmubuntu-latest on check-wasm
notmandatory
approved these changes
Mar 14, 2025
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
ACK 9710ecf
PR description is out of date, but otherwise looks good to go.
Member
Author
|
Done @notmandatory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the
check-wasmjob runner image toubuntu-24.04. It was previously runningubuntu-20.04, which is set to be unsupported in a 3 weeks (see actions/runner-images#11101);clanggets bumped toclang-14because of this.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing