Skip to content

ci: pin minreq to 2.13.2, base64ct to 1.6.0 for MSRV#1886

Merged
ValuedMammal merged 2 commits intobitcoindevkit:masterfrom
luisschwab:ci/msrv-base64ct
Mar 13, 2025
Merged

ci: pin minreq to 2.13.2, base64ct to 1.6.0 for MSRV#1886
ValuedMammal merged 2 commits intobitcoindevkit:masterfrom
luisschwab:ci/msrv-base64ct

Conversation

@luisschwab
Copy link
Copy Markdown
Member

@luisschwab luisschwab commented Mar 11, 2025

Description

Required for #1885 (ubuntu-24.04 on all CI workflows).

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal
Copy link
Copy Markdown
Collaborator

Looks like the same should be done for 1.75. We may also need to pin minreq to fix this

error[E0658]: use of unstable library feature 'once_cell'
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:16
   |
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information

error[E0658]: use of unstable library feature 'once_cell'
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:57
   |
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
   |                                                         ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information

error[E0658]: use of unstable library feature 'once_cell'
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:57
   |
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
   |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information

   Compiling hyper v0.14.32

@LagginTimes LagginTimes added the ci label Mar 11, 2025
@notmandatory notmandatory moved this to In Progress in BDK Chain Mar 11, 2025
@notmandatory notmandatory added this to the 1.2.0 milestone Mar 11, 2025
@luisschwab luisschwab mentioned this pull request Mar 11, 2025
3 tasks
@luisschwab
Copy link
Copy Markdown
Member Author

@ValuedMammal done on #1888 .

@ValuedMammal
Copy link
Copy Markdown
Collaborator

@ValuedMammal done on #1888 .

These should be in the same PR before we can merge.

@luisschwab luisschwab changed the title ci: pin base64ct to 1.6.0 for MSRV ci: pin minreq to 2.13.2, base64ct to 1.6.0 for MSRV Mar 12, 2025
@luisschwab
Copy link
Copy Markdown
Member Author

Done @ValuedMammal

@ValuedMammal
Copy link
Copy Markdown
Collaborator

ValuedMammal commented Mar 12, 2025

Still missing the pin(s) for the 1.75 test in cont_integration.yml. The error is shown here https://github.com/bitcoindevkit/bdk/actions/runs/13801087038/job/38603518407

I know it's confusing because we're pinning deps in two places for different rust versions.

@luisschwab
Copy link
Copy Markdown
Member Author

I know it's confusing because we're pinning deps in two places for different rust versions.

Now I understand what was going on. Both 1.63.0 and 1.75.0 required the same pins, but pin-msrv.sh only pins for 1.63.0.

Copy link
Copy Markdown
Contributor

@LagginTimes LagginTimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a186f00

Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a186f00

@ValuedMammal ValuedMammal merged commit 9af0fd4 into bitcoindevkit:master Mar 13, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in BDK Chain Mar 13, 2025
@luisschwab luisschwab deleted the ci/msrv-base64ct branch March 13, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants