ci: pin minreq to 2.13.2, base64ct to 1.6.0 for MSRV#1886
Merged
ValuedMammal merged 2 commits intobitcoindevkit:masterfrom Mar 13, 2025
Merged
ci: pin minreq to 2.13.2, base64ct to 1.6.0 for MSRV#1886ValuedMammal merged 2 commits intobitcoindevkit:masterfrom
minreq to 2.13.2, base64ct to 1.6.0 for MSRV#1886ValuedMammal merged 2 commits intobitcoindevkit:masterfrom
Conversation
Collaborator
|
Looks like the same should be done for 1.75. We may also need to pin error[E0658]: use of unstable library feature 'once_cell'
--> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:16
|
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information
error[E0658]: use of unstable library feature 'once_cell'
--> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:57
|
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
| ^^^^^^^^^^^^^^^^^^^
|
= note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information
error[E0658]: use of unstable library feature 'once_cell'
--> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/minreq-2.13.3/src/connection.rs:22:57
|
22 | static CONFIG: std::sync::LazyLock<Arc<ClientConfig>> = std::sync::LazyLock::new(|| {
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information
Compiling hyper v0.14.32 |
3 tasks
Member
Author
|
@ValuedMammal done on #1888 . |
Collaborator
These should be in the same PR before we can merge. |
base64ct to 1.6.0 for MSRVminreq to 2.13.2, base64ct to 1.6.0 for MSRV
Member
Author
|
Done @ValuedMammal |
Collaborator
|
Still missing the pin(s) for the 1.75 test in I know it's confusing because we're pinning deps in two places for different rust versions. |
43aa332 to
a186f00
Compare
Member
Author
Now I understand what was going on. Both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
minreqto2.13.2because2.13.3uses the unstablestd::sync::LazyLock(ci: pinminreqto2.13.2,base64ctto1.6.0for MSRV #1886 (comment)).base64ctto1.6.0for MSRV.Required for #1885 (
ubuntu-24.04on all CI workflows).Checklists
All Submissions:
cargo fmtandcargo clippybefore committing