ci: fix publish_docs job fails with "permission denied"#1895
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Mar 17, 2025
Merged
Conversation
notmandatory
approved these changes
Mar 17, 2025
Member
notmandatory
left a comment
There was a problem hiding this comment.
ACK 8b0b3a4
I agree with @ValuedMammal this is worth a try.
@Musab1258 If this doesn't fix the issue please create a new PR to roll it back. Thanks!
3 tasks
Member
|
I think I have a working fix in #1896 which also reverts this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The publish_docs workflow pushes changes to this repository: "bitcoindevkit/bitcoindevkit.org" which requires valid credentials. By setting the persist-credentials to false in #1778, the credentials required are not made available.
Notes to the reviewers
To fix the issue I added a write permission to the publish_jobs, which will allow it to push changes without the credentials.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: