ci: remove not needed nightly_docs workflow

[notmandatory]

Description

I removed the nightly_docs workflow since it's not needed. The latest published bdk crate docs can be found on docs.rs.

Notes to the reviewers

We early in the project life we published nightly docs since the API was changing often and releases were infrequent. But now that the api is more stable and we make regular releases nightly docs aren't needed.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[notmandatory]

@ValuedMammal I think this fixes the permissions issue for #1847, reverts and replaces #1895.

[notmandatory]

Do we even still need bdk nightly docs published to the web site? We already have links there to the docs.rs pages which are what most users should be using. If not then I'll change this PR to remove the nightly_docs.yml workflow.

[Musab1258]

Member

@notmandatory, On this, the nightly doc are not linked on the main page of the website, and I had to search for it before I found it.

I guess this is the link right: https://bitcoindevkit.org/docs-rs/bdk/nightly/latest/bdk_wallet/

[thunderbiscuit]

I don't personally think we need the nightly docs published on the website.

[notmandatory]

I've update this PR to remove the unneeded nightly_docs workflow.

[thunderbiscuit]

ACK 2cba473.