fix(wallet): Remove Debug formatting from Display implementation #1868#1919
Closed
rajanarahul93 wants to merge 1 commit intobitcoindevkit:masterfrom
rajanarahul93:fix-display-debug
Closed
fix(wallet): Remove Debug formatting from Display implementation #1868#1919rajanarahul93 wants to merge 1 commit intobitcoindevkit:masterfrom rajanarahul93:fix-display-debug
rajanarahul93 wants to merge 1 commit intobitcoindevkit:masterfrom
rajanarahul93:fix-display-debug
Conversation
Collaborator
|
This looks like a repeat of #1881 |
Author
|
@ValuedMammal, I will check the #1881 PR and make the required changes!! |
Member
|
This can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
Debugformatting from theDisplayimplementation forLoadErrorincrates/wallet/src/wallet/mod.rs.Instead of using
{:?}(which invokesDebugformatting), we now use{}to provide a more user-friendly error message.This change improves readability and aligns with best practices for
Displayimplementations.Notes to the reviewers
LoadError::Mismatchmessage was updated to explicitly state"expected X, but found Y", making it clearer.LoadError::MissingDescriptormessage now displays the keychain value using{}instead of{:?}, ensuring a more user-friendly output.Changelog notice
Debugformatting fromDisplayimplementation inLoadErrorfor better readability.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes:
resolves #1933