Fix potentially wrong logic if bdk_electrum is used with other chain sources#1956
Closed
evanlinjin wants to merge 1 commit into
Closed
Fix potentially wrong logic if bdk_electrum is used with other chain sources#1956evanlinjin wants to merge 1 commit into
bdk_electrum is used with other chain sources#1956evanlinjin wants to merge 1 commit into
Conversation
bdk_electrum is used with other chain sources
Also clarify logic.
bb31f45 to
0c36df4
Compare
Member
Author
|
No longer relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bdk_electrummay have incorrect reorg-resolution (resulting in inconsistent chain state) if it is paired with other chain sources which do not batch-fetch latest blocks.Also refactored the chain-updating logic to be more understandable.
Notes to the reviewers
This is still WIP. Needs tests, better documentation and PR description.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: