feat(test-utils)!: use bitcoin::Amount instead of u64 on tests#223
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 15303847386Details
💛 - Coveralls |
luisschwab
force-pushed
the
chore/use-amount
branch
from
114a94a to
820a3a0
Compare
luisschwab
force-pushed
the
chore/use-amount
branch
from
820a3a0 to
21a3dcf
Compare
Member
Author
|
Rebased to trigger CI with the new ARM jobs. |
luisschwab
force-pushed
the
chore/use-amount
branch
from
21a3dcf to
bf0a8b0
Compare
Member
Author
|
Now CI is happy again. |
ValuedMammal
changed the title
bitcoin::Amount instead of u64 on testsbitcoin::Amount instead of u64 on tests
Collaborator
|
@luisschwab I changed the PR title to denote that this is an API change in the |
ValuedMammal
force-pushed
the
chore/use-amount
branch
from
bf0a8b0 to
104a301
Compare
Collaborator
|
reACK 104a301 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simply updates tests to use
bitcoin::Amountinstead ofu64.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing