fix: Validate prevouts in get_psbt_input#232
Merged
ValuedMammal merged 2 commits intobitcoindevkit:masterfrom May 28, 2025
Merged
Conversation
Closed
6 tasks
Pull Request Test Coverage Report for Build 15289953340Details
💛 - Coveralls |
Member
|
@evanlinjin please give this one a rebase to fix CI. |
Collaborator
|
Yes I can take a look. |
Co-authored-by: 志宇 <hello@evanlinjin.me>
Added `InvalidOutputIndex` variant to `BuildFeeBumpError`
notmandatory
force-pushed
the
fix/50-validate-prevouts-for-get-psbt-input
branch
from
99d83fe to
6ffc874
Compare
Member
|
I force-pushed a rebase on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50
Fixes #51
Replaces bitcoindevkit/bdk#1911
Replaces bitcoindevkit/bdk#1913
Description
We should check the bounds of the prev txs.
Changelog notice
Fixed: - Wallet::get_psbt_input method now checks bounds when fetching prevout - Wallet::build_fee_bump method now checks bounds when fetching prevoutChecklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes:
* [ ] I've added tests to reproduce the issue which are now passing