feat(wallet): add LoadParams::two_path_descriptor method

[yukibtc]

Description

Added LoadParams::two_path_descriptor to validate that both the external and internal wallet descriptors match an expected two-path descriptor during load.

Changelog notice

• Add LoadParams::two_path_descriptor method

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran just p before pushing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.08%. Comparing base (cb2c7ed) to head (c4dbe42).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   80.04%   80.08%   +0.04%     
==========================================
  Files          24       24              
  Lines        5336     5347      +11     
  Branches      242      242              
==========================================
+ Hits         4271     4282      +11     
  Misses        987      987              
  Partials       78       78              

Flag	Coverage Δ
rust	80.08% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Dmenec]

Approach ACK dbb87b2

Nit: Not sure if there's prior context in the repo, but would it make sense to use "multipath descriptor" following BIP-389 terminology instead of "two-path descriptor"?

[yukibtc]

Nit: Not sure if there's prior context in the repo, but would it make sense to use "multipath descriptor" following BIP-389 terminology instead of "two-path descriptor"?

Thanks for the review.

I've used the "two_path" instead of "multipath" as I see other constructors are named in that way, like Wallet::create_from_two_path_descriptor or CreateParams::new_two_path.

@ValuedMammal @oleonardolima

[ValuedMammal]

ACK c4dbe42

[ValuedMammal]

Here's the prior context on the naming decision for what it's worth #275 (comment)

My one nit is to be careful naming the APIs with the more general multipath convention, as the code and documentation only supports two possible paths. I can see this becoming an issue if Wallet supports N arbitrary keychains in the future, and the functionality of this API changes subtly. My suggestion would be to use something like create_from_two_path_descriptor or similar to distinguish between N possible keychains and two.

[Dmenec]

ACK c4dbe42