Skip to content

refactor: Delegate rusqlite::Connection persister to transaction persister #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shinigami-777 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: Delegate rusqlite::Connection persister to transaction persister #421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5415d0c
refactor: Delegate Connection persister to transaction persister
shinigami-777 Mar 27, 2026
e7abaa5
Merge branch 'bitcoindevkit:master' into rusqlite-connection-persiste…
shinigami-777 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/wallet/persisted.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,16 +284,16 @@ impl WalletPersister for bdk_chain::rusqlite::Connection {
type Error = bdk_chain::rusqlite::Error;

fn initialize(persister: &mut Self) -> Result<ChangeSet, Self::Error> {
let db_tx = persister.transaction()?;
ChangeSet::init_sqlite_tables(&db_tx)?;
let changeset = ChangeSet::from_sqlite(&db_tx)?;
let mut db_tx = persister.transaction()?;
let changeset =
<bdk_chain::rusqlite::Transaction<'_> as WalletPersister>::initialize(&mut db_tx)?;
db_tx.commit()?;
Ok(changeset)
}

fn persist(persister: &mut Self, changeset: &ChangeSet) -> Result<(), Self::Error> {
let db_tx = persister.transaction()?;
changeset.persist_to_sqlite(&db_tx)?;
let mut db_tx = persister.transaction()?;
<bdk_chain::rusqlite::Transaction<'_> as WalletPersister>::persist(&mut db_tx, changeset)?;
db_tx.commit()
}
}
Expand Down