docs(wallet): fix misleading RBF comment in create_tx#422
Open
va-an wants to merge 1 commit intobitcoindevkit:masterfrom
Open
docs(wallet): fix misleading RBF comment in create_tx#422va-an wants to merge 1 commit intobitcoindevkit:masterfrom
create_tx#422va-an wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
=======================================
Coverage 80.04% 80.04%
=======================================
Files 24 24
Lines 5336 5336
Branches 242 242
=======================================
Hits 4271 4271
Misses 987 987
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
ACK 62409a5 I agree the comment was confusing and at least now it better describes what the code is doing. |
ValuedMammal
approved these changes
Apr 7, 2026
luisschwab
suggested changes
Apr 7, 2026
Member
|
Can you squash the commits? |
- Replace incorrect RBF example with sweeping UTXOs - Reorder comment items to match the code's condition order
va-an
force-pushed
the
docs/fix-create-tx-empty-outputs
branch
from
00efc45 to
76a8cc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #45
Changelog notice
Fixed:
Wallet:create_txwhen empty output vectorChecklists
All Submissions:
just pbefore pushing